Add User Details for Clinical Staff in t_visitdetails When a Patient Visits the Facility#219
Add User Details for Clinical Staff in t_visitdetails When a Patient Visits the Facility#219vanitha1822 wants to merge 18 commits into
Quality Gate failed
Failed conditions
18.7% Duplication on New Code (required ≤ 3%)
Annotations
Check warning on line 242 in src/main/java/com/iemr/hwc/service/login/IemrMmuLoginServiceImpl.java
sonarqubecloud / SonarCloud Code Analysis
Replace this instanceof check and cast with 'instanceof Object[] objectArray'
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-OceZNyYxhXOQCMfp2&open=AZ-OceZNyYxhXOQCMfp2&pullRequest=219
Check warning on line 175 in src/main/java/com/iemr/hwc/service/login/IemrMmuLoginServiceImpl.java
sonarqubecloud / SonarCloud Code Analysis
Replace this instanceof check and cast with 'instanceof Object[] objectArray'
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-OceZNyYxhXOQCMfpz&open=AZ-OceZNyYxhXOQCMfpz&pullRequest=219
sonarqubecloud / SonarCloud Code Analysis
Replace generic exceptions with specific library exceptions or a custom exception.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-Oced0yYxhXOQCMfp3&open=AZ-Oced0yYxhXOQCMfp3&pullRequest=219
sonarqubecloud / SonarCloud Code Analysis
Remove this field injection and use constructor injection instead.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-Ocek4yYxhXOQCMfp5&open=AZ-Ocek4yYxhXOQCMfp5&pullRequest=219
Check failure on line 309 in src/main/java/com/iemr/hwc/service/location/LocationServiceImpl.java
sonarqubecloud / SonarCloud Code Analysis
Define a constant instead of duplicating this literal "otherLoc" 3 times.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-OceS_yYxhXOQCMfpp&open=AZ-OceS_yYxhXOQCMfpp&pullRequest=219
Check failure on line 354 in src/main/java/com/iemr/hwc/service/location/LocationServiceImpl.java
sonarqubecloud / SonarCloud Code Analysis
Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-OceS_yYxhXOQCMfpr&open=AZ-OceS_yYxhXOQCMfpr&pullRequest=219
Check warning on line 219 in src/main/java/com/iemr/hwc/service/login/IemrMmuLoginServiceImpl.java
sonarqubecloud / SonarCloud Code Analysis
Use isEmpty() to check whether the collection is empty or not.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-OceZNyYxhXOQCMfp1&open=AZ-OceZNyYxhXOQCMfp1&pullRequest=219
Check failure on line 187 in src/main/java/com/iemr/hwc/controller/location/LocationController.java
sonarqubecloud / SonarCloud Code Analysis
Define a constant instead of duplicating this literal "facilityID" 4 times.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-OceQVyYxhXOQCMfpn&open=AZ-OceQVyYxhXOQCMfpn&pullRequest=219
Check warning on line 237 in src/main/java/com/iemr/hwc/service/login/IemrMmuLoginServiceImpl.java
sonarqubecloud / SonarCloud Code Analysis
Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-OceZNyYxhXOQCMfpv&open=AZ-OceZNyYxhXOQCMfpv&pullRequest=219
Check failure on line 166 in src/main/java/com/iemr/hwc/service/login/IemrMmuLoginServiceImpl.java
sonarqubecloud / SonarCloud Code Analysis
Refactor this method to reduce its Cognitive Complexity from 23 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-OceZNyYxhXOQCMfpy&open=AZ-OceZNyYxhXOQCMfpy&pullRequest=219
Check warning on line 194 in src/main/java/com/iemr/hwc/service/login/IemrMmuLoginServiceImpl.java
sonarqubecloud / SonarCloud Code Analysis
Use isEmpty() to check whether the collection is empty or not.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-OceZNyYxhXOQCMfp0&open=AZ-OceZNyYxhXOQCMfp0&pullRequest=219
Check failure on line 292 in src/main/java/com/iemr/hwc/service/choApp/CHOAppSyncServiceImpl.java
sonarqubecloud / SonarCloud Code Analysis
Define a constant instead of duplicating this literal "vanID" 8 times.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-Ocem-yYxhXOQCMfqA&open=AZ-Ocem-yYxhXOQCMfqA&pullRequest=219
sonarqubecloud / SonarCloud Code Analysis
Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-OceoPyYxhXOQCMfqD&open=AZ-OceoPyYxhXOQCMfqD&pullRequest=219
Check warning on line 354 in src/main/java/com/iemr/hwc/service/location/LocationServiceImpl.java
sonarqubecloud / SonarCloud Code Analysis
Remove this unused method parameter "spPSMID".
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-OceS_yYxhXOQCMfps&open=AZ-OceS_yYxhXOQCMfps&pullRequest=219
Check warning on line 260 in src/main/java/com/iemr/hwc/service/login/IemrMmuLoginServiceImpl.java
sonarqubecloud / SonarCloud Code Analysis
Replace generic exceptions with specific library exceptions or a custom exception.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-OceZNyYxhXOQCMfpx&open=AZ-OceZNyYxhXOQCMfpx&pullRequest=219
sonarqubecloud / SonarCloud Code Analysis
Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-OceoPyYxhXOQCMfqE&open=AZ-OceoPyYxhXOQCMfqE&pullRequest=219
Check failure on line 188 in src/main/java/com/iemr/hwc/controller/location/LocationController.java
sonarqubecloud / SonarCloud Code Analysis
Define a constant instead of duplicating this literal "spPSMID" 3 times.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-OceQVyYxhXOQCMfpo&open=AZ-OceQVyYxhXOQCMfpo&pullRequest=219
Check warning on line 399 in src/main/java/com/iemr/hwc/service/location/LocationServiceImpl.java
sonarqubecloud / SonarCloud Code Analysis
Use isEmpty() to check whether the collection is empty or not.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-OceS_yYxhXOQCMfpu&open=AZ-OceS_yYxhXOQCMfpu&pullRequest=219
Check warning on line 208 in src/main/java/com/iemr/hwc/service/login/IemrMmuLoginServiceImpl.java
sonarqubecloud / SonarCloud Code Analysis
Replace generic exceptions with specific library exceptions or a custom exception.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-OceZNyYxhXOQCMfpw&open=AZ-OceZNyYxhXOQCMfpw&pullRequest=219
Check warning on line 362 in src/main/java/com/iemr/hwc/service/location/LocationServiceImpl.java
sonarqubecloud / SonarCloud Code Analysis
Replace this instanceof check and cast with 'instanceof Object[] objectArray'
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-OceS_yYxhXOQCMfpt&open=AZ-OceS_yYxhXOQCMfpt&pullRequest=219
sonarqubecloud / SonarCloud Code Analysis
Use a StringBuilder instead.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-Oced0yYxhXOQCMfp4&open=AZ-Oced0yYxhXOQCMfp4&pullRequest=219
sonarqubecloud / SonarCloud Code Analysis
Remove this field injection and use constructor injection instead.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-Ocek4yYxhXOQCMfp6&open=AZ-Ocek4yYxhXOQCMfp6&pullRequest=219
Check failure on line 278 in src/main/java/com/iemr/hwc/service/choApp/CHOAppSyncServiceImpl.java
sonarqubecloud / SonarCloud Code Analysis
Define a constant instead of duplicating this literal "beneficiaryConsent" 10 times.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-Ocem-yYxhXOQCMfp8&open=AZ-Ocem-yYxhXOQCMfp8&pullRequest=219
Check failure on line 182 in src/main/java/com/iemr/hwc/service/choApp/CHOAppSyncServiceImpl.java
sonarqubecloud / SonarCloud Code Analysis
Refactor this method to reduce its Cognitive Complexity from 60 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-Ocem-yYxhXOQCMfqB&open=AZ-Ocem-yYxhXOQCMfqB&pullRequest=219
Check failure on line 288 in src/main/java/com/iemr/hwc/service/choApp/CHOAppSyncServiceImpl.java
sonarqubecloud / SonarCloud Code Analysis
Define a constant instead of duplicating this literal "parkingPlaceID" 8 times.
See more on https://sonarcloud.io/project/issues?id=PSMRI_HWC-API&issues=AZ-Ocem-yYxhXOQCMfp_&open=AZ-Ocem-yYxhXOQCMfp_&pullRequest=219