Skip to content

Added .__eq__ and .__hash__ to BaseMesh - #2776

Merged
erikvansebille merged 2 commits into
mainfrom
warning-on-particle-mesh-mismatch-too-strict
Jul 28, 2026
Merged

Added .__eq__ and .__hash__ to BaseMesh#2776
erikvansebille merged 2 commits into
mainfrom
warning-on-particle-mesh-mismatch-too-strict

Conversation

@wyatt-fluidnumerics

Copy link
Copy Markdown
Contributor

Description

After converting different mesh types to be classes in #2739 the hashing method used for identifying equal meshes breaks. The fix is to add .eq and .hash methods to the BaseMesh class.

Checklist

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.
    • Describe how you used it (e.g., by pasting your prompt): I used claude code in plan mode to get information about how python's hash function hashes tuples. All code was written by myself.

@erikvansebille
erikvansebille merged commit 22e203d into main Jul 28, 2026
32 of 33 checks passed
@erikvansebille
erikvansebille deleted the warning-on-particle-mesh-mismatch-too-strict branch July 28, 2026 05:24
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Parcels development Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Unexpected warning about different meshes when combining models

2 participants