to_windowed_arrays only for non-underway instruments - #361
Merged
Conversation
Co-authored-by: Erik van Sebille <e.vansebille@uu.nl>
erikvansebille
approved these changes
Jul 27, 2026
erikvansebille
left a comment
erikvansebille
left a comment
Member
There was a problem hiding this comment.
Looks good. Happy to be merged when green ticks
Collaborator
Author
Great, thanks. Note, certain unit tests are expected to fail (meaning we won't get all green ticks in the PR) but will be addressed in the target #342 branch/PR. They are left to fail for now though to ensure they do not get missed later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a check if an instrument is/not an underway instrument (
ADCP,UnderwaterST). If not, then useto_windowed_arrays. Otherwise leave as the default NumPy/Dask backed fieldset thefieldset.evalin the underway simulation methods.All instruments now all have a property method for their
InstrumentType(in base.py), which means theis_underwayattribute becomes accessible. Related unit tests added for all instruments.Please note test failures are expected, and will be addressed in root #342 PR