Add support for Sinister Jewel sockets#2277
Merged
LocalIdentity merged 6 commits intoJun 29, 2026
Merged
Conversation
adds support for sinister jewel sockets granted by amulet anoints and Voices, including Zarokh's Gift. granted sockets now apply in calculator environments, update main build socket state only during the main calc pass, and are removed cleanly when the granting anoint/item goes away. also fixes the anoint picker so Zarokh's Gift appears by adding the new 0.5 emotions to the filter list, and verifies tooltip comparisons include jewels socketed into prospective Zarokh sockets.
Added already in a different PR
Uses the sinister jewel count from ModParser now Cleans up some duplicated code
Now mark the sockets in the tree export so it's easier to check them in different files Now stops the sockets working with Adorned
|
great work; thank you. However, would there be any value to explicitly name the sockets as "Sinister Sockets #" for visual clarity? This way you can also block uniques in dropdown? (unless you're already doing so)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
intended to add support for sinister jewel sockets granted by Voices and Zarokh's Gift. granted sockets now apply in calculator environments, update main build socket state only during the main calc pass, and are removed cleanly when the granting anoint/item goes away.
also wanted to fix the anoint picker so Zarokh's Gift appears by adding the new 0.5 emotions to the filter list, and verify tooltip comparisons include jewels socketed.
dynamically adds or removes socketables from the items UI with persistent socket allocation
Steps taken to verify a working solution:
Screenshots