Fix Adorned not scaling Time-Lost jewels#2327
Open
LocalIdentity wants to merge 1 commit into
Open
Conversation
The Adorned is meant to scale the mods granted by Time-Lost jewels but it seems we never implemented it Since Time-Lost jewel mods are treated differently we need to have a bunch of logic to fix the notable display and the scaling logic in CalcSetup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2305
Description of the problem being solved:
The Adorned is meant to scale the mods granted by Time-Lost jewels but it seems we never implemented it
Since Time-Lost jewel mods are treated differently, we need to have a bunch of logic to fix the notable display and the scaling logic in CalcSetup
Also seems to fix some issue with regular jewels not being scaled by Adorned too
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/53gcow0h
Before screenshot:
After screenshot: