Skip to content

fix(m0e): one dialect — CLI strings, docs, and distilled README match shipped reality#122

Open
PatrickSys wants to merge 6 commits into
feat/work-native-authority-v2-1from
pivot/m0e-surface-convergence
Open

fix(m0e): one dialect — CLI strings, docs, and distilled README match shipped reality#122
PatrickSys wants to merge 6 commits into
feat/work-native-authority-v2-1from
pivot/m0e-surface-convergence

Conversation

@PatrickSys

Copy link
Copy Markdown
Owner

Summary

  • Align CLI help and init/update wording around the current .work/ contract while keeping legacy state-folder reads explicit.
  • Make runtime strings derive from the basename of the resolved state directory instead of hardcoding a state folder name.
  • Rewrite distilled/README.md and package metadata to use plain proof-first framing without jargon or registry overclaims.
  • Add a permanent public surface gate for help/docs banned terms, legacy state-folder wording, and retired helper commands.

Verification

  • node bin/gsdd.mjs help
  • node tests/gsdd.surface.test.cjs
  • npm test
  • Fresh init output .planning count: 0
  • Legacy fixture verify output names .planning/phases/...

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions the workspace directory name from .planning/ to .work/ (while maintaining legacy support), updates documentation and package descriptions to use a plain, jargon-free 'proof-first' framing, and introduces a new test suite (tests/gsdd.surface.test.cjs) to enforce these language and surface constraints. Feedback on the changes suggests filtering files in the docs directory to only include .md files in the new surface test to prevent errors when reading non-markdown assets.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +52 to +58
function publicDocFiles() {
return [
path.join(ROOT, 'README.md'),
path.join(ROOT, 'distilled', 'README.md'),
...listFiles(path.join(ROOT, 'docs')),
];
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Reading all files in the docs directory recursively can be inefficient and error-prone if there are non-markdown files (such as images or other assets) present. It is safer and more robust to filter the files to only include .md files before reading them as UTF-8 strings.

function publicDocFiles() {
  const docsDir = path.join(ROOT, 'docs');
  const docsFiles = fs.existsSync(docsDir) ? listFiles(docsDir).filter(f => f.endsWith('.md')) : [];
  return [
    path.join(ROOT, 'README.md'),
    path.join(ROOT, 'distilled', 'README.md'),
    ...docsFiles,
  ];
}

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7182d14161

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread distilled/README.md Outdated
- Codex CLI uses the always-generated `.agents/skills/gsdd-*` surface as its entry path, relies on `.planning/bin/gsdd.mjs` for deterministic helper calls, and can add a native `.codex/agents/gsdd-plan-checker.toml` checker agent.
- `control-map` is a helper command, not a lifecycle workflow: it computes repo/worktree/planning truth first and treats `.planning/.local/` annotations as local intent only. `control-map annotate` can maintain those annotations, but cannot create ownership, cleanup, or lifecycle authority.
- Codex CLI uses the always-generated `.agents/skills/gsdd-*` surface as its entry path, relies on `.work/bin/gsdd.mjs` for deterministic helper calls, and can add a native `.codex/agents/gsdd-plan-checker.toml` checker agent.
- `control-map` is a helper command, not a lifecycle workflow: it computes repo/worktree/planning truth first and treats `.work/.local/` annotations as local intent only. `control-map annotate` can maintain those annotations, but cannot create ownership, cleanup, or lifecycle authority.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove docs for the retired control-map command

When readers follow this distilled README, control-map is not registered in the COMMANDS map in bin/gsdd.mjs (and closeout-report from the same helper section is missing too), so npx -y gsdd-cli control-map ... falls through to help and exits 1. This keeps a retired helper in the public surface despite the new surface gate; remove/update these references or restore the command before publishing the docs.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant