fix(m0e): one dialect — CLI strings, docs, and distilled README match shipped reality#122
fix(m0e): one dialect — CLI strings, docs, and distilled README match shipped reality#122PatrickSys wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request transitions the workspace directory name from .planning/ to .work/ (while maintaining legacy support), updates documentation and package descriptions to use a plain, jargon-free 'proof-first' framing, and introduces a new test suite (tests/gsdd.surface.test.cjs) to enforce these language and surface constraints. Feedback on the changes suggests filtering files in the docs directory to only include .md files in the new surface test to prevent errors when reading non-markdown assets.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| function publicDocFiles() { | ||
| return [ | ||
| path.join(ROOT, 'README.md'), | ||
| path.join(ROOT, 'distilled', 'README.md'), | ||
| ...listFiles(path.join(ROOT, 'docs')), | ||
| ]; | ||
| } |
There was a problem hiding this comment.
Reading all files in the docs directory recursively can be inefficient and error-prone if there are non-markdown files (such as images or other assets) present. It is safer and more robust to filter the files to only include .md files before reading them as UTF-8 strings.
function publicDocFiles() {
const docsDir = path.join(ROOT, 'docs');
const docsFiles = fs.existsSync(docsDir) ? listFiles(docsDir).filter(f => f.endsWith('.md')) : [];
return [
path.join(ROOT, 'README.md'),
path.join(ROOT, 'distilled', 'README.md'),
...docsFiles,
];
}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7182d14161
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Codex CLI uses the always-generated `.agents/skills/gsdd-*` surface as its entry path, relies on `.planning/bin/gsdd.mjs` for deterministic helper calls, and can add a native `.codex/agents/gsdd-plan-checker.toml` checker agent. | ||
| - `control-map` is a helper command, not a lifecycle workflow: it computes repo/worktree/planning truth first and treats `.planning/.local/` annotations as local intent only. `control-map annotate` can maintain those annotations, but cannot create ownership, cleanup, or lifecycle authority. | ||
| - Codex CLI uses the always-generated `.agents/skills/gsdd-*` surface as its entry path, relies on `.work/bin/gsdd.mjs` for deterministic helper calls, and can add a native `.codex/agents/gsdd-plan-checker.toml` checker agent. | ||
| - `control-map` is a helper command, not a lifecycle workflow: it computes repo/worktree/planning truth first and treats `.work/.local/` annotations as local intent only. `control-map annotate` can maintain those annotations, but cannot create ownership, cleanup, or lifecycle authority. |
There was a problem hiding this comment.
Remove docs for the retired control-map command
When readers follow this distilled README, control-map is not registered in the COMMANDS map in bin/gsdd.mjs (and closeout-report from the same helper section is missing too), so npx -y gsdd-cli control-map ... falls through to help and exits 1. This keeps a retired helper in the public surface despite the new surface gate; remove/update these references or restore the command before publishing the docs.
Useful? React with 👍 / 👎.
Summary
.work/contract while keeping legacy state-folder reads explicit.distilled/README.mdand package metadata to use plain proof-first framing without jargon or registry overclaims.Verification
node bin/gsdd.mjs helpnode tests/gsdd.surface.test.cjsnpm test.planningcount:0.planning/phases/...