PG-2513: Make client connected flag atomic#40
Open
dutow wants to merge 2 commits into
Open
Conversation
This fixes a possible race as it can be used by multiple threads, e.g. Also clean up the order of pointer cleanup and connected flag unset. The client code is still thread unsafe even with this change, but it at least makes the connected handling more consistent.
It had an overly defensive LLM style, when in reality it could be much simpler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a possible race as it can be used by multiple threads, e.g.
Also clean up the order of pointer cleanup and connected flag unset. The client code is still thread unsafe even with this change, but it at least makes the connected handling more consistent.