fix: use seekable resource for seeks instead of refetching - #220
Merged
Conversation
|
All Contributors have signed the CLA. The PR is now allowed to be merged. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
performanc-bot
added a commit
to PerformanC/CLA-Signatures
that referenced
this pull request
Aug 8, 2026
1Lucas1apk
approved these changes
Aug 9, 2026
ToddyTheNoobDud
approved these changes
Aug 9, 2026
Member
|
Thanks for your contribuition! :) |
Member
|
Thank you for finding and fixing the problem, eternally grateful ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added seek support using
createSeekeableAudioResourcein_connectAndPlayStream, so it skips the full re-fetch/reconnect when seeking. Falls back to the old_fetchResourcemethod if it fails or the source/protocol isn't supported (local,deezer,sabr,hls,dash)Why
&t=Xtimestamps were always ignored, track just started from 0 regardless of position. It's actually worse than just "seek doesn't work" though, since track-end is scheduled based ontrackLength - startPosition, the track gets cut off early too. e.g. seek to 1:43 on a 2:34 track and it'll stop around 0:51 of real playback, since the audio was actually playing from 0:00 the whole time.Checkmarks
Additional information
tsc + biome pass