Skip to content

Consolidate compiler types into HIR#6760

Merged
proggeramlug merged 2 commits into
chore/workspace-architecture-baseline-phase1from
refactor/merge-perry-types-into-hir
Jul 22, 2026
Merged

Consolidate compiler types into HIR#6760
proggeramlug merged 2 commits into
chore/workspace-architecture-baseline-phase1from
refactor/merge-perry-types-into-hir

Conversation

@TheHypnoo

Copy link
Copy Markdown
Member

Summary

  • move the compiler type definitions and their unit tests into perry_hir::types
  • migrate compiler consumers and remove every perry-types Cargo dependency
  • delete the standalone crate and refresh the workspace architecture baseline and documentation

Architecture impact

  • workspace members: 78 -> 77
  • default members: 1 -> 1
  • CLI/default dependency closure: 18 -> 17
  • keep an explicit perry_hir::types interface without broad root reexports

Validation

  • python3 scripts/workspace_architecture.py --self-test
  • python3 scripts/workspace_architecture.py --check --print-summary
  • cargo metadata --no-deps --format-version 1
  • cargo fmt --all -- --check
  • git diff --check
  • cargo check -p perry
  • cargo test -p perry-hir --lib
  • cargo test -p perry-transform
  • cargo test -p perry-codegen-arkts -p perry-codegen-js -p perry-codegen-swiftui -p perry-codegen-wasm
  • Clippy for all modified compiler packages and cargo clippy -p perry --bins
  • final repository search found no perry-types or perry_types references

Existing test debt

  • full cargo test -p perry-hir reaches an unrelated existing failure in logical_property_assignment_short_circuits_the_store_4586; this PR changes only its import path
  • full cargo test -p perry-codegen reaches an unrelated stale CompileOptions::namespace_reexport_named_imports field in i64_spec_ternary_recursion; this PR changes only its import path

Dependency

This PR is stacked on #6758 because the workspace architecture baseline is still open. Merge #6758 first, then retarget this PR to main.

Next phase

Phase 2B can merge perry-ext-http-server into perry-ext-http as a separate change.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0360acef-7c53-4470-9047-94973888a447

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/merge-perry-types-into-hir

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

TheHypnoo added a commit that referenced this pull request Jul 22, 2026
@TheHypnoo
TheHypnoo force-pushed the refactor/merge-perry-types-into-hir branch from c3f0787 to abd3c95 Compare July 22, 2026 11:44
@proggeramlug
proggeramlug merged commit 7f33783 into chore/workspace-architecture-baseline-phase1 Jul 22, 2026
3 checks passed
@proggeramlug
proggeramlug deleted the refactor/merge-perry-types-into-hir branch July 22, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants