Skip to content

refactor(http): route HTTP bindings through perry-ffi#6834

Merged
proggeramlug merged 2 commits into
refactor/merge-http-server-into-httpfrom
refactor/http-ffi-boundary
Jul 25, 2026
Merged

refactor(http): route HTTP bindings through perry-ffi#6834
proggeramlug merged 2 commits into
refactor/merge-http-server-into-httpfrom
refactor/http-ffi-boundary

Conversation

@TheHypnoo

@TheHypnoo TheHypnoo commented Jul 25, 2026

Copy link
Copy Markdown
Member

Summary

  • Route production perry-ext-http runtime calls through narrow perry-ffi operations.
  • Remove the normal perry-ext-http -> perry-runtime edge and its staticlib workaround.
  • Keep the selected libperry_ext_http.a artifact and exported HTTP ABI unchanged.
  • Add the required changelog fragment in changelog.d/6834-http-ffi-boundary.md.

Proof

  • cargo tree -p perry-ext-http --edges normal has no perry-runtime.
  • Production HTTP code has no perry_runtime:: references; explicit test shims retain the test-only dev dependency.
  • Release export comparison: 215 -> 215 relevant HTTP symbols, empty diff.
  • cargo test -p perry-ffi --features runtime-link: 49 passed.
  • cargo test -p perry-ext-http: 68 passed.
  • Architecture self-test/check and Cargo metadata passed.

Scope

This stacked PR excludes Phase 4 stdlib HTTP deduplication and unrelated cleanup.

Known CI limitations

PR #6826 remains blocked by its inherited lint failure (the Phase 2B head has a pre-existing cargo fmt --all -- --check diff in crates/perry-hir/src/lower/builder_fold.rs) and several conformance jobs. A full release binary link-and-run smoke exceeded the local two-minute command limit after repeated incremental builds; the release HTTP archive and 215-symbol comparison passed.

Related issue

N/A — Perry architecture roadmap Phase 3.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fd6d8534-8447-4626-be13-617fd7f53ebe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/http-ffi-boundary

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug
proggeramlug merged commit aa7dd7a into refactor/merge-http-server-into-http Jul 25, 2026
3 checks passed
@proggeramlug
proggeramlug deleted the refactor/http-ffi-boundary branch July 25, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants