test(gc): de-duplicate the matrix corpus entry registered twice by #6977 - #7011
Merged
Conversation
…ix corpus #6977 registered the file in two places, so the corpus held 23 entries with 22 unique names. It ran twice per arm, inflating every gc_repsel_matrix.sh count by 20 cells and skewing the collected/moved liveness denominators. Kept the first block (which explains the UNREGISTERED gate that #6925 tripped) and dropped the second.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe GC representation-selection corpus manifest now identifies the collection-performing stress test, and a changelog entry documents how a duplicate corpus entry inflated parity matrix cells and liveness denominators. ChangesGC representation-selection corpus corrections
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-parity/gc_repsel_corpus.txtheld 23 entries with 22 unique names —test_gap_repsel_proven_this_frozenwas registered twice, both blocks added by #6977 documenting the same thing (that #6925 landed the file without registering it, tripping theUNREGISTEREDgate).Why it isn't cosmetic
The corpus drives
scripts/gc_repsel_matrix.sh. A duplicated row runs that file twice per arm, which:393a36aa4reported 460 cells where 440 was correct;collected 22/23,moved-objects 22/23), which are exactly the figures used to decide whether an arm was live enough for its green cells to mean anything.Conclusions drawn from the affected runs were unaffected — the duplicate row passes or fails identically both times — but the totals are not comparable across runs taken before and after the duplication, which matters because the campaign is tracking a delta.
Change
Dropped the second block, kept the first (its comment explains the
UNREGISTEREDgate). No test files added or removed; no behaviour change.Found while re-measuring the matrix after today's GC series.
Summary by CodeRabbit
Bug Fixes
Tests