style(gc): rustfmt triggers.rs to unblock lint on main - #7180
Closed
proggeramlug wants to merge 1 commit into
Closed
style(gc): rustfmt triggers.rs to unblock lint on main#7180proggeramlug wants to merge 1 commit into
proggeramlug wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe change reformats one Rust assertion to satisfy ChangesLint formatting correction
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Superseded by #7181 (identical rustfmt fix, merged minutes earlier — two agents found the blocker in parallel). Thanks — closing as duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lintis red onmain. #7161 landed with arustfmtviolation in the test it added, socargo fmt --all -- --checkfails — and that job is required for every PR, so every open PR is blocked until this lands.Reproduced against
origin/mainitself (5a06970b6), not against a branch:Formatting only — the applied change is exactly
rustfmt's output, no behaviour change and no other file touched. Found while rebasing #7179 onto the merged #7161.Refs #7161.
Summary by CodeRabbit