Skip to content

style(gc): rustfmt triggers.rs to unblock lint on main - #7180

Closed
proggeramlug wants to merge 1 commit into
mainfrom
fix/7161-fmt-lint-unblock
Closed

style(gc): rustfmt triggers.rs to unblock lint on main#7180
proggeramlug wants to merge 1 commit into
mainfrom
fix/7161-fmt-lint-unblock

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Summary

lint is red on main. #7161 landed with a rustfmt violation in the test it added, so cargo fmt --all -- --check fails — and that job is required for every PR, so every open PR is blocked until this lands.

Diff in crates/perry-runtime/src/gc/tests/triggers.rs:438:
 fn test_moving_loop_minor_off_by_default_7154() {
-    assert!(!enabled(None), "moving-loop minor must be OFF by default (#7154)");
+    assert!(
+        !enabled(None),
+        "moving-loop minor must be OFF by default (#7154)"
+    );

Reproduced against origin/main itself (5a06970b6), not against a branch:

git show origin/main:crates/perry-runtime/src/gc/tests/triggers.rs > /tmp/t.rs
rustfmt --edition 2021 --check /tmp/t.rs   # emits the diff above

Formatting only — the applied change is exactly rustfmt's output, no behaviour change and no other file touched. Found while rebasing #7179 onto the merged #7161.

Refs #7161.

Summary by CodeRabbit

  • Chores
    • Unblocked lint checks by correcting a formatting violation.
    • No runtime behavior or user-facing functionality changed.

#7161 landed with a rustfmt violation in the new
test_moving_loop_minor_off_by_default_7154, which fails
`cargo fmt --all -- --check` — the lint job every PR must pass.
Formatting only, no behaviour change.

Refs #7161
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fbec9975-ebe5-43a6-a752-1519fa414748

📥 Commits

Reviewing files that changed from the base of the PR and between 5a06970 and 8f7847c.

📒 Files selected for processing (2)
  • changelog.d/7180-fmt-lint-unblock.md
  • crates/perry-runtime/src/gc/tests/triggers.rs

📝 Walkthrough

Walkthrough

The change reformats one Rust assertion to satisfy rustfmt and adds a changelog entry. It does not change behavior or public declarations.

Changes

Lint formatting correction

Layer / File(s) Summary
Reformat GC assertion
crates/perry-runtime/src/gc/tests/triggers.rs, changelog.d/7180-fmt-lint-unblock.md
The default-off assertion now uses multiline formatting. The existing condition and failure message remain unchanged. The changelog records the formatting-only correction.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the rustfmt-only change that unblocks lint in triggers.rs.
Description check ✅ Passed The description explains the problem, change, related issue, verification steps, and confirms that behavior is unchanged.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/7161-fmt-lint-unblock

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug

Copy link
Copy Markdown
Contributor Author

Superseded by #7181 (identical rustfmt fix, merged minutes earlier — two agents found the blocker in parallel). Thanks — closing as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant