chore: finalize #7185 maintainer landing metadata - #7186
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe PR updates scalar root fixture references from ChangesScalar root fixture updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
proggeramlug
force-pushed
the
maintainer/pr-7185-release-ready
branch
from
August 1, 2026 13:30
5b54930 to
e6c8838
Compare
proggeramlug
marked this pull request as ready for review
August 1, 2026 13:31
proggeramlug
force-pushed
the
maintainer/pr-7185-release-ready
branch
from
August 1, 2026 13:32
e6c8838 to
b568242
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7185 landed while this same-repository maintainer branch was being prepared. The contributor commit correctly omitted release metadata, so this follow-up supplies the required 0.5.1277 patch bump and keeps the remaining scalar-root comments and panic diagnostics consistent with
js_shadow_frame_enter.It also resolves the review wording nit without changing the already-landed fixture assertions.
Verification:
cargo test -p perry-codegen --test scalar_replaced_slot_roots(11/11)cargo fmt --all -- --checkgit diff --checkFollow-up to #7185.
Summary by CodeRabbit
Chores
Bug Fixes
Tests