Skip to content

chore: finalize #7185 maintainer landing metadata - #7186

Merged
proggeramlug merged 1 commit into
mainfrom
maintainer/pr-7185-release-ready
Aug 1, 2026
Merged

chore: finalize #7185 maintainer landing metadata#7186
proggeramlug merged 1 commit into
mainfrom
maintainer/pr-7185-release-ready

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

#7185 landed while this same-repository maintainer branch was being prepared. The contributor commit correctly omitted release metadata, so this follow-up supplies the required 0.5.1277 patch bump and keeps the remaining scalar-root comments and panic diagnostics consistent with js_shadow_frame_enter.

It also resolves the review wording nit without changing the already-landed fixture assertions.

Verification:

  • cargo test -p perry-codegen --test scalar_replaced_slot_roots (11/11)
  • cargo fmt --all -- --check
  • git diff --check

Follow-up to #7185.

Summary by CodeRabbit

  • Chores

    • Updated the application version to 0.5.1277.
    • Synchronized the documented version information across project materials.
  • Bug Fixes

    • Documented corrections related to fixture behavior, diagnostics, whitespace handling, test comments, and panic messages.
  • Tests

    • Updated test expectations to align with the latest runtime behavior.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8686d327-dfe0-4ff4-bd46-cc54fe695f36

📥 Commits

Reviewing files that changed from the base of the PR and between d8be5f4 and b568242.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • CLAUDE.md
  • Cargo.toml
  • changelog.d/7186-scalar-replaced-slot-roots-fixtures.md
  • crates/perry-codegen/tests/scalar_replaced_slot_roots.rs

📝 Walkthrough

Walkthrough

The PR updates scalar root fixture references from js_shadow_frame_push to js_shadow_frame_enter, adds a changelog entry, and increments the documented and workspace versions to 0.5.1277.

Changes

Scalar root fixture updates

Layer / File(s) Summary
Align scalar root fixtures with shadow-frame entry
crates/perry-codegen/tests/scalar_replaced_slot_roots.rs, changelog.d/7186-scalar-replaced-slot-roots-fixtures.md
Test diagnostics and comments now refer to js_shadow_frame_enter. The changelog records the related fixture corrections.
Update release version metadata
Cargo.toml, CLAUDE.md
The workspace package version and documented current version now use 0.5.1277.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • PerryTS/perry#7185: Updates the same scalar root test expectations for the shadow-frame API rename.
  • PerryTS/perry#7007: Introduced the shadow-frame API rename reflected by these tests.
  • PerryTS/perry#7065: Contains related shadow-stack closure-rooting changes for the renamed API.

Suggested reviewers: jdalton

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch maintainer/pr-7185-release-ready

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

#7185 landed while its same-repository maintainer branch was being prepared, but the contributor commit intentionally did not carry release metadata. Bump the workspace to 0.5.1277 and make the remaining scalar-root diagnostics consistently name js_shadow_frame_enter.

Refs #7185.
@proggeramlug
proggeramlug force-pushed the maintainer/pr-7185-release-ready branch from e6c8838 to b568242 Compare August 1, 2026 13:32
@proggeramlug proggeramlug changed the title test(codegen): update scalar-root fixtures for frame enter chore: finalize #7185 maintainer landing metadata Aug 1, 2026
@proggeramlug
proggeramlug merged commit 5ef83bb into main Aug 1, 2026
8 of 37 checks passed
@proggeramlug
proggeramlug deleted the maintainer/pr-7185-release-ready branch August 1, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant