Skip to content

chore(version): restore the version past its high-water mark - #7222

Merged
proggeramlug merged 1 commit into
PerryTS:mainfrom
jdalton:fix/restore-version-high-water
Aug 2, 2026
Merged

chore(version): restore the version past its high-water mark#7222
proggeramlug merged 1 commit into
PerryTS:mainfrom
jdalton:fix/restore-version-high-water

Conversation

@jdalton

@jdalton jdalton commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

main is publishing a patch version it already shipped. It reached 0.5.1278, then went backwards to 0.5.1277, and five commits have landed on top since without anyone catching it.

This sets it to 0.5.1279 — the next unused patch above the old high-water mark — in Cargo.toml, Cargo.lock, and the **Current Version:** line.

How it happened — a stale base, merged without a rebase

#7196 was branched when main was at 0.5.1276 and bumped itself to 0.5.1277, which was correct at the time. While it sat in review, main moved to 0.5.1278. Merging it without a rebase carried the older version line in and overwrote the newer one.

The version at each recent commit on main:

Commit Version
1679e22b4 and earlier 0.5.1278
91170973c (#7196 merged) 0.5.1277 ← regression
dd83c7e92 0.5.1277
a3496427b (#7206) 0.5.1277
fa4a7ab99 (#7214) 0.5.1277
7d1dc9ca2 (#7212) 0.5.1277

Nothing was wrong with any of those five PRs. The version is a single shared line that only the merge step touches, so once it went backwards it stayed there — each subsequent merge inherited the wrong value rather than re-introducing the problem.

Why 0.5.1279 rather than 0.5.1278

0.5.1278 was already published on main for a stretch of commits. Re-using it would mean two different trees carrying the same patch version, which is worse than the gap. Skipping to 0.5.1279 leaves 1278 burned and moves forward cleanly.

What this is not

This is not a routine bump, so it does not conflict with the contributor rule in CLAUDE.md that says outside PRs should leave the version alone. That rule exists to stop in-flight PRs colliding on the patch number — which is precisely the failure being repaired here. The version line is the entire content of this PR.

The underlying cause is worth a separate look: nothing currently prevents a merge from lowering the version. A check comparing the incoming **Current Version:** against the one on main would have caught this at PR time, and would also have caught it on any of the five PRs that inherited it.

Validation

Ran: cargo update --workspace to refresh Cargo.lock (version lines only — the workspace crates move 0.5.1277 → 0.5.1279, no dependency changes), and cargo metadata to confirm the workspace still resolves.

Did not run: the full test suite or a release build. This change touches three metadata files and no source, so there is nothing behavioral to exercise.

Note on CI: lint is currently red on main for reasons unrelated to this PR — it fails at "Audit workspace architecture", and the 2000-line file-size gate is separately red for 16 files. Both predate this change.

Summary by CodeRabbit

  • Chores
    • Updated the project version to 0.5.1279.
    • Added a changelog entry documenting the version update.
    • Updated the documented current version for consistency.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 49031948-16a6-4c3a-a1e2-d469edc7f7db

📥 Commits

Reviewing files that changed from the base of the PR and between 24a82f0 and 00d4ab4.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • CLAUDE.md
  • Cargo.toml
  • changelog.d/7222-restore-version-high-water.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • Cargo.toml
  • CLAUDE.md

📝 Walkthrough

Walkthrough

The project version was restored from 0.5.1277 to 0.5.1279 in workspace metadata and documentation. A changelog entry records the restoration.

Changes

Version restoration

Layer / File(s) Summary
Restore version metadata
Cargo.toml, CLAUDE.md, changelog.d/7222-restore-version-high-water.md
The workspace and documented versions now use 0.5.1279. The changelog records the version restoration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • PerryTS/perry#7224: Updates the same project version metadata from 0.5.1277 to a newer version.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: restoring the project version above its previous high-water mark.
Description check ✅ Passed The description clearly explains the regression, affected files, rationale, validation, and test limitations, so it is mostly complete despite missing formal template sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jdalton
jdalton force-pushed the fix/restore-version-high-water branch from 3a979a0 to 24a82f0 Compare August 1, 2026 22:50

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@changelog.d/7217-restore-version-high-water.md`:
- Line 1: Rename the changelog fragment from 7217-restore-version-high-water.md
to 7222-restore-version-high-water.md, preserving its existing contents and the
required <PR>-<slug>.md format.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a45681b8-3524-4703-9254-2f28e991f146

📥 Commits

Reviewing files that changed from the base of the PR and between 7d1dc9c and 24a82f0.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • CLAUDE.md
  • Cargo.toml
  • changelog.d/7217-restore-version-high-water.md

Comment thread changelog.d/7222-restore-version-high-water.md
main was at 0.5.1278 and regressed to 0.5.1277 when PerryTS#7196 merged from a
stale base. Five commits have landed since without catching it, so main
has been carrying a patch version it already shipped.

Bumped to 0.5.1279 — the next unused patch above the old high-water
mark — in Cargo.toml, Cargo.lock and the Current Version line.
@jdalton
jdalton force-pushed the fix/restore-version-high-water branch from 24a82f0 to 00d4ab4 Compare August 1, 2026 23:14
@proggeramlug
proggeramlug merged commit a0a9d5f into PerryTS:main Aug 2, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants