Skip to content

test(gc): register the dark call-argument witness from #7252 #7263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proggeramlug merged 1 commit into from
Aug 2, 2026
Merged

test(gc): register the dark call-argument witness from #7252 #7263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions changelog.d/7263-register-dark-call-arg-witness.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
`test_gap_gc_call_argument_rooting` shipped with #7252 but was never added to
`test-parity/gc_repsel_corpus.txt`, so it never ran anywhere. Registering it is
the whole fix.

This is the third occurrence of the same mistake (#7192 and #7216 are documented
in that file directly above), and the first one caught automatically: the
`test_gap_gc_*` enforcement added in response to the earlier two failed the
`GC Moving Witnesses` job on its first main-line run — which only happened at
all because #7253 gave that matrix a main-line trigger.
10 changes: 10 additions & 0 deletions test-parity/gc_repsel_corpus.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,16 @@ test_gap_gc_closure_call_callee_rooting
test_gap_gc_closure_call_this_rooting
test_gap_gc_closure_call_argument_rooting

# --- A THIRD witness that was registered nowhere (#7252) --------------------
# `test_gap_gc_call_argument_rooting` shipped with #7252 (cross-module direct
# call argument rooting, authored by @jdalton, restacked at merge). Same defect
# as #7192 and #7216 above: the PR added the witness and did not add the line.
Comment on lines +290 to +292

@coderabbitai coderabbitai Bot Aug 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Correct the stale relative-location reference.

Line 292 says that #7192 and #7216 are documented “above.” Their section starts at Line 299, below this block. Change “above” to “below.”

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test-parity/gc_repsel_corpus.txt` around lines 290 - 292, Update the comment
for test_gap_gc_call_argument_rooting to change the relative-location reference
from “above” to “below,” since the referenced sections appear later in the file.

# It was dark from merge until the `test_gap_gc_*` enforcement added for those
# two caught it on the first `GC Moving Witnesses` run on main -- which is the
# enforcement working exactly as designed, on the third occurrence of the same
# mistake. Registering the file is the whole fix.
test_gap_gc_call_argument_rooting

# --- Two witnesses that were registered nowhere (#7192, #7216) ---------------
# Both files exist in test-files/, both say in their own headers that they are
# LIVE BY CONSTRUCTION and bite only on the moving arms, and neither was in this
Expand Down
Loading