fix(bench): regenerate the public Node/Bun baseline, and register the batch kernel (#7257) - #7285
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
📝 WalkthroughWalkthroughThe PR regenerates benchmark measurements and reports for the 2026-08-03 sweep. It refreshes honest-bench data, comparison tables, runtime metadata, the public baseline, app-pattern registration, and the related changelog entry. ChangesBenchmark regeneration
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related issues
Possibly related PRs
Suggested labels: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7257.
Regenerates
benchmarks/results/public-node-bun-v1.json, stale for 40+ commits, and fixes the manifest bug that made regenerating it impossible.Why this mattered more than a stale file
The freshness check is
lint's step 9. Steps run in order and stop at the first failure, so while it failed, steps 10–13 never executed in CI at all:lint)All four had to be reproduced locally to even be seen (#7256, #7273). And because
lintis a required check, every merge went through--adminbypass — branch protection was theatre. A permanently-red required gate does not protect anything.The manifest bug (#7037)
EXPECTED_WORKLOADS["app_patterns"]never gained thebatchkernel that #7037 added tobenchmarks/app-patterns/kernels/. So #7037 both invalidated the artifact (kernels are inSOURCE_PATHS) and made regenerating it impossible: assembly aborts withextra=['batch']after all five measurement legs have already run — two hours in. Adding a kernel must add it here in the same commit.The original host (
Sergi.local) belongs to another maintainer and was unavailable. Regenerating on this machine was a deliberate call by the maintainer, accepting a documented discontinuity rather than leaving the artifact stale indefinitely.Node, Bun and Zig are held at their original pins (
v22.23.1,1.3.14,0.15.2) even though the harness allows overriding them — so the discontinuity is one variable, not three. Anyone reading a step in the series at this commit should attribute it to hardware, not to Perry.What the run covers
All five legs, on a quiet host, in one coherent run at
defa4d601: suite, polyglot, json_polyglot, app-patterns, honest_bench.honest_bench --strict-outputpassed — all rows matched the Bun reference, which was not a given on a faster host, since that reference was calibrated on the slower one.The
json_polyglotleg was impossible until today. It aborts on a cross-runtime checksum mismatch, and Perry was producing a wrong answer — #7264, aJSON.stringifydata-loss bug fixed by #7265. This artifact is the first to include that leg since.Deliberately not included
No README change.
renderwrites a generated table intoREADME.md, but thepublic-node-bun:start/endmarkers were deleted by #6736's landing-page rewrite, and the freshness gate treats the embedded table as optional. Restoring them would publish a fresh comparison table mid-optimization-cycle; the maintainer's call is to update the README once the current performance work concludes. Tracked separately.Verified
benchmarks/ci_public_baseline_check.py→public baseline freshness OK(the exactlintstep 9 command)public_baseline.py assemble/render/checkall succeedgenerated_atis2026-08-03T05:53:58Z— verified by reading the field, never by file mtime (git worktree addrewrites mtimes and has produced a false "complete" report on this task before)Summary by CodeRabbit
Benchmark Updates
batchworkload.Documentation