docs: one engine plan — fold in the representation-selection campaign - #7293
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdded a consolidated engine plan and changelog entry. The plan covers GC rooting, statepoints, LLVM requirements, RSS measurements, benchmark findings, representation analysis, active work tracks, and implementation sequencing. ChangesEngine planning documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were five documents and issues describing parts of the same effort, plus a 55 KB working plan that existed only as an uncommitted file on one machine. If that laptop died, the campaign's reasoning died with it. This makes
docs/engine-plan.mdthe single entry point; detail stays in the linked RFCs.What got folded in
The representation-selection campaign's durable results, which were nowhere in the repo:
Strat −4.12% from deleting two opaque runtime calls per iteration.js_*calls removed from hot paths, never promotion counts — the metric that would have predicted that null in advance.Why now
2026-08-03's measurements confirm the framing precisely. The three worst benchmarks lose on a missing proof, not a missing representation:
matrix_multiplyprime_sieveAnd the proof that is missing is not "is this an i32" —
(i*size+k)|0produces genuine i32 and buys nothing, because|0hasmin < 0. What is missing is non-negativity plus an upper bound (#7286).The plan also records #7287, which contradicts our own scoreboard:
method_callshas zerojs_*calls in its hot loop and is 7.9× behind — it is guard-bound. A metric we adopted for good reasons is necessary but not sufficient, and it is better to write that down than to keep scoring a win on that workload class.Structure
engine-plan.mdcarries sequencing and rationale. Detail lives insrc/internals/rfc-rooting-by-construction.md(three rooting layers + the in-process-LLVM enabler, #7292) andsrc/internals/gc-rooting-invariant.md(the invariant and the checker's three blind spots, #7289).Docs only. The 55 KB local file is superseded and can be deleted.
Summary by CodeRabbit