ci(gc): stop the bridge job compiling a probe the bridge now refuses (#7335) - #7337
Conversation
|
Warning Review limit reached
Next review available in: 5 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #7335.
native-roots-aarch64is red onmainright now, and #7330 (mine) caused it.#7330 made the explicit bridge refuse a module it cannot root — since #7302 every call inside a
tryis aninvoke, and the bridge cannot express a statepoint on one (#7327). But five steps of that job still compiled09_try_catch_rootsunder the bridge, one by hardcoded path. Nobody saw it because CI has been stalled for hours.The fix
01_nursery_churninstead.native-roots-rs4gc-aarch64is unchanged and still covers 09 — RS4GC does handle invokes.The part that matters more than the skip
A skip that is not itself checked is just missing coverage. So the job now asserts the refusal happens: compiling 09 under the bridge must fail, and must fail with the #7327 diagnostic rather than for some unrelated reason.
If the bridge ever learns invokes, that step goes red and tells you to re-enable 09 in the globs above — so the skip cannot quietly outlive its reason.
Workflow parses; file-size, GC store-site, addr-class and gate-wiring checks green.