Skip to content

ci(gc): stop the bridge job compiling a probe the bridge now refuses (#7335) - #7337

Merged
proggeramlug merged 1 commit into
mainfrom
fix/7335-bridge-job-probe09
Aug 3, 2026
Merged

ci(gc): stop the bridge job compiling a probe the bridge now refuses (#7335)#7337
proggeramlug merged 1 commit into
mainfrom
fix/7335-bridge-job-probe09

Conversation

@proggeramlug

Copy link
Copy Markdown
Contributor

Fixes #7335. native-roots-aarch64 is red on main right now, and #7330 (mine) caused it.

#7330 made the explicit bridge refuse a module it cannot root — since #7302 every call inside a try is an invoke, and the bridge cannot express a statepoint on one (#7327). But five steps of that job still compiled 09_try_catch_roots under the bridge, one by hardcoded path. Nobody saw it because CI has been stalled for hours.

The fix

  • The bridge job skips probe 09 in its four probe globs, and its report step uses 01_nursery_churn instead.
  • native-roots-rs4gc-aarch64 is unchanged and still covers 09 — RS4GC does handle invokes.

The part that matters more than the skip

A skip that is not itself checked is just missing coverage. So the job now asserts the refusal happens: compiling 09 under the bridge must fail, and must fail with the #7327 diagnostic rather than for some unrelated reason.

If the bridge ever learns invokes, that step goes red and tells you to re-enable 09 in the globs above — so the skip cannot quietly outlive its reason.

Workflow parses; file-size, GC store-site, addr-class and gate-wiring checks green.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proggeramlug, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9aad3b15-02f4-4f0c-8e06-4af5108246bd

📥 Commits

Reviewing files that changed from the base of the PR and between e98dfdb and 19fdfce.

📒 Files selected for processing (2)
  • .github/workflows/gc-native-roots.yml
  • changelog.d/7337-bridge-job-probe09.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug
proggeramlug merged commit 07354cb into main Aug 3, 2026
29 of 46 checks passed
@proggeramlug
proggeramlug deleted the fix/7335-bridge-job-probe09 branch August 3, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: native-roots-aarch64 is red on main — #7330's invoke refusal makes 09_try_catch_roots uncompilable in five of its steps

1 participant