test(gc): re-pin ratchet after accepted collector shifts - #7921
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR adds a changelog entry for the re-pinned GC ratchet baseline. The entry records updated live-byte accounting, nursery allocation, bounded untraced promotion, grow-then-churn behavior, promotion work, and pinned-host footprint. ChangesGC ratchet documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
proggeramlug
marked this pull request as ready for review
August 12, 2026 06:38
proggeramlug
pushed a commit
that referenced
this pull request
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7843
What changed
98e9ecdb5(perry 0.5.1484).The artifact was measured before rebasing this artifact-only branch over #7907/#7912, so its recorded commit and code-tree provenance remain the exact tree that produced the numbers.
Reproduction and acceptance rationale
The old
a1fd5a7e8pin fails on frozen main in two independent seven-repeat runs with byte-identical shared-CI counters:03_cross_gen_writes: two additional copied objects,copied_bytes590,688 -> 656,256 (+65,568), while retained heap and RSS both fall.14_grow_then_churn: 19 minors / 20 steps, 13,013 copied objects, 403,514 promoted objects, and 151,713,056 promoted bytes in both runs.heapUsedfalls 91.4%; pinned-host RSS rises about 4x.These are consequences of already reviewed and merged collector changes, not measurement noise:
heapUsedwith live-byte accounting, explaining the large retention improvements.No tolerance or probe definition changes. The new artifact passes both gate profiles against the fresh measurement.
Validation
PYTHONPATH="$PWD" python3 tests/test_gc_ratchet.py— 91 passedgc_ratchet.py validate— passedgc_ratchet.py check --profile shared_ci— passed against the new pingc_ratchet.py check --profile pinned_host— passed against the new pingit diff --check— passedbash scripts/check_file_size.sh— passedAdjacent observation
The pin driver records the full suite with
--warn-only. It reported existing/current timing regressions for Fibonacci (+23%) andbench_numeric_array_numeric(+1000%) while all correctness checks passed. This PR does not open a separate issue or mix those unrelated performance investigations into the GC ratchet re-pin.Summary by CodeRabbit