Fix aggregate_per_date() combining results using last file's columns …#75
Open
fredho-42 wants to merge 1 commit into
Open
Conversation
…instead of first After looping over all time-series files, aggregate_per_date() combined per-file results and set the final table's column count/names from whichever file happened to be processed *last* (ci/dsnames were reused directly from the final loop iteration). This made the result silently depend on file processing order/completeness. Now each file's (ds, dsnames) pair is collected in a list and combined afterwards with purrr::list_rbind(), using the *first* file's dsnames as the canonical column names/count. Verified against a synthetic multi-subject dataset: output is identical to the previous implementation in the well-behaved case (same column count for every file).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After looping over all time-series files, aggregate_per_date() combined per-file results and set the final table's column count/names from whichever file happened to be processed last (ci/dsnames were reused directly from the final loop iteration). This made the result silently depend on file processing order/completeness, and won't be compatible when there're multiple bout lengths.
Now each file's (ds, dsnames) pair is collected in a list and combined afterwards with purrr::list_rbind(), using the first file's dsnames as the canonical column names/count.
Verified against a synthetic multi-subject dataset: output is identical to the previous implementation in the well-behaved case (same column count for every file).