Bump phoebe_ws submodule to drop unused L2G weight#765
Open
griswaldbrooks wants to merge 1 commit into
Open
Conversation
Advances the phoebe_ws gitlink to the for-example-ws-no-dups commit that removes src/phoebe_sim/models/l2g.onnx (unlicensed, orphaned). This is the step that makes example_ws stop shipping the weight; the phoebe_ws-side removal already merged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis pull request updates the ChangesSubmodule Pointer Update
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[written by AI]
Problem
moveit_pro_example_wsconsumesphoebe_wsvia a pinned submodule gitlink (branchfor-example-ws-no-dups). The phoebe-side removal of the orphaned, unlicensedl2g.onnx(PickNikRobotics/phoebe_ws#30, merged) does not reach example_ws until the gitlink advances.Change
Bump
src/external_dependencies/phoebe_wsfrombaeff373to6764983(the mergedfor-example-ws-no-dupsHEAD that dropssrc/phoebe_sim/models/l2g.onnx). Submodule-pointer-only; no other files.Part of ML-weight licensing cleanup: epic PickNikRobotics/moveit_pro#20347, L2G ticket PickNikRobotics/moveit_pro#20353.
Release notes
None