Skip to content

docs: player-facing factual fixes + voice-rewrite teardown for ship (Pip review)#650

Merged
PipFoweraker merged 4 commits into
mainfrom
docs/player-facing-audit
Jul 20, 2026
Merged

docs: player-facing factual fixes + voice-rewrite teardown for ship (Pip review)#650
PipFoweraker merged 4 commits into
mainfrom
docs/player-facing-audit

Conversation

@PipFoweraker

@PipFoweraker PipFoweraker commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Ship-hygiene pass over player-facing docs (README top priority). Two kinds of change, kept deliberately separate.

The core truth (verified in code)

game_state.gd check_win_lose() (L518-523) only ever sets victory=false, on doom>=100 or reputation<=0. There is no doom<=0 victory branch and victory is never set true anywhere. The game is unwinnable by design (ADR-0002 / DQ-1 victory-removal, RESOLVED). All fixes below use the true thesis: you can't win — you can only buy time; survival duration is the score; every run ends in loss; a good run beats your own baseline. (An earlier revision of this PR wrongly described a doom→0 "apex victory," following stale prose in the ADR-0002 document — that has been purged everywhere; see the audit report's correction note.)

Factual fixes — safe to merge

  • README — removed the advertised "Survive 100 turns with P(Doom) at 0%" win condition AND the About-para "…whether P(Doom) reaches 0% or humanity faces extinction" win-lie → buy-time framing. Fixed dead docs/CONTRIBUTORS.md link.
  • STEAM_INTEGRATION_ROADMAP — version v0.10.5 → v0.11.0 (×2); purged both win-lies in the store copy (short description + gameplay bullet).
  • PLAYERGUIDE — corrected false "Python/Pygame version" note; dropped dead CONFIG_SYSTEM.md link.
  • docs/README (index) — removed two all-dead link sections (8 dead links) + literal CLIPBOARD/MICROSCOPE emoji-token garbage + dead Dev Tools link.
  • CONTRIBUTING — removed dead docs/CONTRIBUTORS.md link.
  • QUICK_REFERENCE — version v0.4.1 → v0.11.0.

12 factual fixes total. No .import churn; settings.local.json excluded.

Voice teardowns — your worklist, not done here

docs/qa/PLAYER_FACING_AUDIT_2026-07-16.md is the primary deliverable: verdict table + per-doc skeletons (README pitch, PLAYERGUIDE full rewrite — it documents the pygame-era game, DEMO_GUIDE archive, Steam store copy, PRIVACY, CHANGELOG L1-wave entries).

Findings for other lanes (NOT fixed here)

  • In-game HUD center string "Win: P(Doom) = 0% or beat baseline | Lose: P(Doom) = 100%" is the same stale win-lie, live in the game — owned by the HUD/code lane.
  • ADR-0002 doc prose is itself stale (claims a doom<=0 code victory that doesn't exist) — reconcile to DQ-1.
  • Steam achievement table ("First Victory: Win your first game", "Safety Champion: Win with 0% doom", …) is win-based and invalid for an unwinnable game — must be redesigned around survival milestones by the achievements lane (also references deleted legacy python).

Note: AP → Attention wording was deliberately flagged, not rewritten — AP still co-exists in the shipped build (L2/#613 not built yet).

Please don't merge blind: the factual half is safe; the teardown half is for you.

🤖 Generated with Claude Code

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

PipFoweraker and others added 3 commits July 21, 2026 07:52
Ship-hygiene pass over player-facing docs. Two change types kept separate:

FACTUAL FIXES (safe, applied here):
- README: remove advertised "Survive 100 turns with P(Doom) at 0%" win
  condition — contradicts ADR-0002 (survival/high-score spine; doom-0 is a
  rare apex, not a timed win; no turn limit). Fix dead docs/CONTRIBUTORS.md link.
- STEAM_INTEGRATION_ROADMAP: version v0.10.5 -> v0.11.0 (x2); same win-condition
  error in the store-copy block.
- PLAYERGUIDE: correct false "Python/Pygame version" note (pure GDScript now);
  drop dead CONFIG_SYSTEM.md link.
- docs/README index: remove two all-dead link sections (Summaries/Analysis) +
  literal CLIPBOARD/MICROSCOPE emoji-token garbage + dead Dev Tools link.
- CONTRIBUTING: remove dead docs/CONTRIBUTORS.md link.
- QUICK_REFERENCE: version v0.4.1 -> v0.11.0.

VOICE TEARDOWNS (Pip's worklist, NOT rewritten):
- docs/qa/PLAYER_FACING_AUDIT_2026-07-16.md: verdict table + per-doc skeletons
  for README pitch, PLAYERGUIDE full rewrite, DEMO_GUIDE (archive), etc.
  AP->Attention wording deliberately left as flags (AP still lives pre-#613).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… victory)

Coordinator correction: game_state.gd check_win_lose() (L518-523) only ever
sets victory=false, on doom>=100 or reputation<=0. There is NO doom<=0 victory
branch; `victory` is never set true anywhere. The game cannot be won, exactly as
ADR-0002 / DQ-1 (victory-removal, RESOLVED) intend.

Purges the earlier "doom->0 is a rare apex victory" framing (which followed stale
ADR-0002 prose) from every player-facing fix:
- README: gameplay bullet + About para -> "you can't win, only buy time; every
  run ends in loss; a good run beats your own baseline".
- STEAM_INTEGRATION_ROADMAP: store short-description + gameplay bullet, same purge.
- PLAYER_FACING_AUDIT report: rewrote the "one truth" section to the unwinnable
  thesis (with the code proof), added a superseding correction note, fixed all
  skeleton/teardown notes, and recorded two do-not-fix findings for other lanes:
  (1) the in-game HUD "Win: P(Doom) = 0% or beat baseline" string is the same
  stale lie; (2) ADR-0002 doc prose is itself stale re: a code victory that
  doesn't exist.

Flagged (not rewritten — another lane / speculative internal mapping): the Steam
achievement table's win-based entries ("First Victory: Win your first game", etc.)
are invalid for an unwinnable game and must be redesigned around survival.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Reconciliation of overlapping player-facing audit PRs. PLAYERGUIDE.md is
owned by the parallel #719 lane; its two factual fixes (Python/Pygame note,
dead CONFIG_SYSTEM.md link) are flagged in the audit doc for that lane
instead of being carried here. Restored PLAYERGUIDE.md to origin/main and
updated the audit verdict table + fix count (12 -> 10) to match.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@PipFoweraker
PipFoweraker force-pushed the docs/player-facing-audit branch from 9ce3df4 to b39df9e Compare July 20, 2026 22:16
@PipFoweraker

Copy link
Copy Markdown
Owner Author

Reconciled against current origin/main (reconciliation lane)

This PR was based on a main from before yesterday's big merges (#725/#726 rivals + attribution, #736 living-roadmap). Reconciled today:

Rebased onto current origin/main -- clean, zero conflicts.

Dropped docs/PLAYERGUIDE.md -- handed to the #719 truth-pass lane.
Per the reconciliation scope (in-game strings + non-PLAYERGUIDE docs only), PLAYERGUIDE.md was restored to origin/main and the two factual fixes it carried are now flagged for #719 instead of applied here:

  • "The Python/Pygame version is for development only" -> stale (pure GDScript now).
  • dead [CONFIG_SYSTEM.md] link -> file absent.

The audit doc's verdict table now marks both as HANDED TO #719 and the fix count is corrected 12 -> 10.

Relationship to #715: file sets are completely disjoint -- #650 is markdown docs, #715 is in-game strings/code. No overlap, so both stay as separate PRs (no combined branch needed).

Tests: docs-only PR (no code). The sibling code branch (#715) passed the fast gate green (533 tests, 0 fail) after its own rebase.

Note: the audit doc + README carry a few em-dashes / the pre-existing coffee emoji. enforce-standards treats Unicode as non-blocking (auto-fixer warning only), so this does not block the commit -- left as-authored for your review.

…I rule

Pip 2026-07-21: no non-ASCII anywhere in this repo, long-standing rule.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@PipFoweraker
PipFoweraker merged commit 7b9e750 into main Jul 20, 2026
5 checks passed
@PipFoweraker
PipFoweraker deleted the docs/player-facing-audit branch July 20, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant