docs: player-facing factual fixes + voice-rewrite teardown for ship (Pip review)#650
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Ship-hygiene pass over player-facing docs. Two change types kept separate: FACTUAL FIXES (safe, applied here): - README: remove advertised "Survive 100 turns with P(Doom) at 0%" win condition — contradicts ADR-0002 (survival/high-score spine; doom-0 is a rare apex, not a timed win; no turn limit). Fix dead docs/CONTRIBUTORS.md link. - STEAM_INTEGRATION_ROADMAP: version v0.10.5 -> v0.11.0 (x2); same win-condition error in the store-copy block. - PLAYERGUIDE: correct false "Python/Pygame version" note (pure GDScript now); drop dead CONFIG_SYSTEM.md link. - docs/README index: remove two all-dead link sections (Summaries/Analysis) + literal CLIPBOARD/MICROSCOPE emoji-token garbage + dead Dev Tools link. - CONTRIBUTING: remove dead docs/CONTRIBUTORS.md link. - QUICK_REFERENCE: version v0.4.1 -> v0.11.0. VOICE TEARDOWNS (Pip's worklist, NOT rewritten): - docs/qa/PLAYER_FACING_AUDIT_2026-07-16.md: verdict table + per-doc skeletons for README pitch, PLAYERGUIDE full rewrite, DEMO_GUIDE (archive), etc. AP->Attention wording deliberately left as flags (AP still lives pre-#613). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… victory)
Coordinator correction: game_state.gd check_win_lose() (L518-523) only ever
sets victory=false, on doom>=100 or reputation<=0. There is NO doom<=0 victory
branch; `victory` is never set true anywhere. The game cannot be won, exactly as
ADR-0002 / DQ-1 (victory-removal, RESOLVED) intend.
Purges the earlier "doom->0 is a rare apex victory" framing (which followed stale
ADR-0002 prose) from every player-facing fix:
- README: gameplay bullet + About para -> "you can't win, only buy time; every
run ends in loss; a good run beats your own baseline".
- STEAM_INTEGRATION_ROADMAP: store short-description + gameplay bullet, same purge.
- PLAYER_FACING_AUDIT report: rewrote the "one truth" section to the unwinnable
thesis (with the code proof), added a superseding correction note, fixed all
skeleton/teardown notes, and recorded two do-not-fix findings for other lanes:
(1) the in-game HUD "Win: P(Doom) = 0% or beat baseline" string is the same
stale lie; (2) ADR-0002 doc prose is itself stale re: a code victory that
doesn't exist.
Flagged (not rewritten — another lane / speculative internal mapping): the Steam
achievement table's win-based entries ("First Victory: Win your first game", etc.)
are invalid for an unwinnable game and must be redesigned around survival.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Reconciliation of overlapping player-facing audit PRs. PLAYERGUIDE.md is owned by the parallel #719 lane; its two factual fixes (Python/Pygame note, dead CONFIG_SYSTEM.md link) are flagged in the audit doc for that lane instead of being carried here. Restored PLAYERGUIDE.md to origin/main and updated the audit verdict table + fix count (12 -> 10) to match. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
9ce3df4 to
b39df9e
Compare
Reconciled against current
|
…I rule Pip 2026-07-21: no non-ASCII anywhere in this repo, long-standing rule. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Ship-hygiene pass over player-facing docs (README top priority). Two kinds of change, kept deliberately separate.
The core truth (verified in code)
game_state.gd check_win_lose()(L518-523) only ever setsvictory=false, ondoom>=100orreputation<=0. There is nodoom<=0victory branch andvictoryis never settrueanywhere. The game is unwinnable by design (ADR-0002 / DQ-1 victory-removal, RESOLVED). All fixes below use the true thesis: you can't win — you can only buy time; survival duration is the score; every run ends in loss; a good run beats your own baseline. (An earlier revision of this PR wrongly described a doom→0 "apex victory," following stale prose in the ADR-0002 document — that has been purged everywhere; see the audit report's correction note.)Factual fixes — safe to merge
docs/CONTRIBUTORS.mdlink.v0.10.5 → v0.11.0(×2); purged both win-lies in the store copy (short description + gameplay bullet).CONFIG_SYSTEM.mdlink.CLIPBOARD/MICROSCOPEemoji-token garbage + dead Dev Tools link.docs/CONTRIBUTORS.mdlink.v0.4.1 → v0.11.0.12 factual fixes total. No
.importchurn;settings.local.jsonexcluded.Voice teardowns — your worklist, not done here
docs/qa/PLAYER_FACING_AUDIT_2026-07-16.mdis the primary deliverable: verdict table + per-doc skeletons (README pitch, PLAYERGUIDE full rewrite — it documents the pygame-era game, DEMO_GUIDE archive, Steam store copy, PRIVACY, CHANGELOG L1-wave entries).Findings for other lanes (NOT fixed here)
"Win: P(Doom) = 0% or beat baseline | Lose: P(Doom) = 100%"is the same stale win-lie, live in the game — owned by the HUD/code lane.doom<=0code victory that doesn't exist) — reconcile to DQ-1.Note:
AP → Attentionwording was deliberately flagged, not rewritten — AP still co-exists in the shipped build (L2/#613 not built yet).Please don't merge blind: the factual half is safe; the teardown half is for you.
🤖 Generated with Claude Code