Skip to content

fix: include publishing docs in assemble - #696

Merged
marandaneto merged 4 commits into
mainfrom
fix/dokka-publishing-locks
Aug 11, 2026
Merged

fix: include publishing docs in assemble#696
marandaneto merged 4 commits into
mainfrom
fix/dokka-publishing-locks

Conversation

@marandaneto

@marandaneto marandaneto commented Aug 11, 2026

Copy link
Copy Markdown
Member

💡 Motivation and Context

The posthog 6.29.2 release failed while creating its Javadoc artifact. Three Dokka dependencies had been removed from the Gradle lockfiles for posthog and posthog-server. The regular PR build did not create the published documentation artifacts, so it did not resolve those dependencies or catch the incomplete lockfiles.

This restores the missing lock entries. It also adds the Javadoc and HTML documentation jars to assemble for posthog, posthog-server, and posthog-android-gradle-plugin. The existing make compile CI step now creates the same documentation artifacts used during publishing and fails if their dependency locks are incomplete.

No changeset is included because this does not change SDK code or package behavior.

💚 How did you test it?

  • make compile
  • make updateLocks
  • make checkFormat
  • make dryReleaseCore
  • make dryReleaseServer
  • make dryReleaseAndroid
  • make dryReleaseAndroidPlugin
  • Removed the three Dokka entries locally and verified that ./gradlew :posthog:assemble --rerun-tasks failed with the same missing-lock error as the release
  • git diff --check

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran pnpm changeset to generate a changeset file

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Pi coding agent investigated the failed release logs and implemented the fix in a dedicated worktree. We chose to make published documentation part of each relevant module's normal assembly instead of adding special cases to the root Makefile or CI workflow. The final autoreview was skipped at the human driver's request.

@marandaneto marandaneto self-assigned this Aug 11, 2026
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor
⚠️ 3 packages modified but this PR has no changeset

This is informational — the PR is not blocked. Click the triangle above to collapse, or push a fix and this comment will auto-delete.

Modified in this PR but no changeset added:

  • posthog
  • posthog-android-gradle-plugin
  • posthog-server

If this change should ship, run pnpm changeset and select a bump level.
If it isn't user-facing (refactor with no behavior change, internal tooling, generated files), no action needed.

@marandaneto
marandaneto marked this pull request as ready for review August 11, 2026 10:53
@marandaneto
marandaneto requested a review from a team as a code owner August 11, 2026 10:53
@marandaneto

Copy link
Copy Markdown
Member Author

@marandaneto
marandaneto requested a review from dmarchuk August 11, 2026 10:53
@greptile-apps

greptile-apps Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "ci: keep compile before checking depende..." | Re-trigger Greptile

@marandaneto
marandaneto enabled auto-merge (squash) August 11, 2026 10:55
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

posthog-android Compliance Report

Date: 2026-08-11 11:32:33 UTC
Duration: 118500ms

✅ All Tests Passed!

46/46 tests passed


Capture Tests

29/29 tests passed

View Details
Test Status Duration
Format Validation.Event Has Required Fields 426ms
Format Validation.Event Has Uuid 30ms
Format Validation.Event Has Lib Properties 33ms
Format Validation.Distinct Id Is String 28ms
Format Validation.Token Is Present 27ms
Format Validation.Custom Properties Preserved 30ms
Format Validation.Event Has Timestamp 26ms
Retry Behavior.Retries On 503 7024ms
Retry Behavior.Does Not Retry On 400 4025ms
Retry Behavior.Does Not Retry On 401 4022ms
Retry Behavior.Respects Retry After Header 7024ms
Retry Behavior.Implements Backoff 17034ms
Retry Behavior.Retries On 500 7021ms
Retry Behavior.Retries On 502 7019ms
Retry Behavior.Retries On 504 7020ms
Retry Behavior.Max Retries Respected 17034ms
Deduplication.Generates Unique Uuids 40ms
Deduplication.Preserves Uuid On Retry 7014ms
Deduplication.Preserves Uuid And Timestamp On Retry 12030ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 7019ms
Deduplication.No Duplicate Events In Batch 38ms
Deduplication.Different Events Have Different Uuids 25ms
Compression.Sends Gzip When Enabled 18ms
Batch Format.Uses Proper Batch Structure 28ms
Batch Format.Flush With No Events Sends Nothing 13ms
Batch Format.Multiple Events Batched Together 35ms
Error Handling.Does Not Retry On 403 4020ms
Error Handling.Does Not Retry On 413 4021ms
Error Handling.Retries On 408 5026ms

Feature_Flags Tests

17/17 tests passed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 36ms
Request Payload.Flags Request Uses V2 Query Param 28ms
Request Payload.Flags Request Hits Flags Path Not Decide 24ms
Request Payload.Flags Request Omits Authorization Header 28ms
Request Payload.Token In Flags Body Matches Init 23ms
Request Payload.Groups Round Trip 22ms
Request Payload.Groups Default To Empty Object 26ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False 25ms
Request Payload.Disable Geoip Omitted Defaults To False 23ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key 27ms
Request Lifecycle.No Flags Request On Init Alone 20ms
Request Lifecycle.No Flags Request On Normal Capture 26ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests 35ms
Request Lifecycle.Mock Response Value Is Returned To Caller 17ms
Retry Behavior.Retries Flags On 502 324ms
Retry Behavior.Retries Flags On 504 320ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event 26ms

@marandaneto
marandaneto disabled auto-merge August 11, 2026 10:58
@marandaneto marandaneto changed the title fix: validate Dokka publishing locks in CI fix: include publishing docs in assemble Aug 11, 2026
@marandaneto
marandaneto enabled auto-merge (squash) August 11, 2026 11:26
@marandaneto
marandaneto merged commit d8f6987 into main Aug 11, 2026
17 checks passed
@marandaneto
marandaneto deleted the fix/dokka-publishing-locks branch August 11, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants