fix: include publishing docs in assemble - #696
Merged
Merged
Conversation
Contributor
|
marandaneto
marked this pull request as ready for review
August 11, 2026 10:53
Contributor
|
Reviews (1): Last reviewed commit: "ci: keep compile before checking depende..." | Re-trigger Greptile |
marandaneto
enabled auto-merge (squash)
August 11, 2026 10:55
Contributor
posthog-android Compliance ReportDate: 2026-08-11 11:32:33 UTC ✅ All Tests Passed!46/46 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
marandaneto
disabled auto-merge
August 11, 2026 10:58
marandaneto
enabled auto-merge (squash)
August 11, 2026 11:26
dmarchuk
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The
posthog6.29.2 release failed while creating its Javadoc artifact. Three Dokka dependencies had been removed from the Gradle lockfiles forposthogandposthog-server. The regular PR build did not create the published documentation artifacts, so it did not resolve those dependencies or catch the incomplete lockfiles.This restores the missing lock entries. It also adds the Javadoc and HTML documentation jars to
assembleforposthog,posthog-server, andposthog-android-gradle-plugin. The existingmake compileCI step now creates the same documentation artifacts used during publishing and fails if their dependency locks are incomplete.No changeset is included because this does not change SDK code or package behavior.
💚 How did you test it?
make compilemake updateLocksmake checkFormatmake dryReleaseCoremake dryReleaseServermake dryReleaseAndroidmake dryReleaseAndroidPlugin./gradlew :posthog:assemble --rerun-tasksfailed with the same missing-lock error as the releasegit diff --check📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi coding agent investigated the failed release logs and implemented the fix in a dedicated worktree. We chose to make published documentation part of each relevant module's normal assembly instead of adding special cases to the root
Makefileor CI workflow. The final autoreview was skipped at the human driver's request.