feat(metrics): add prometheus latency histogram for /api/rate-limit - #698
Merged
greatest0fallt1me merged 1 commit intoJul 28, 2026
Merged
Conversation
|
@Ajibola6921 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Adds a `rate_limit_request_duration_seconds` histogram to track request latency for the /api/rate-limit endpoint, segmented by route and status code, with explicit buckets. The middleware is registered on the router before auth so that latency for rejected requests is also captured. Closes Predictify-org#642
Ajibola6921
force-pushed
the
fix/rate-limit-histogram-642
branch
from
July 28, 2026 13:20
f7cfa03 to
9f89774
Compare
Contributor
|
LGTM — thoughtful approach, thanks for taking this on! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a Prometheus latency histogram for the
/api/rate-limitendpoint, tracking request duration segmented by route template and status code with explicit buckets. The middleware is registered on the router ahead of auth so that latency for rejected requests (e.g. 403) is captured as well, not just successful 200s.Related Issue
Closes #642
Changes
Metrics
rate_limit_request_duration_secondshistogram insrc/metrics/registry.tswith explicit buckets[0.01, 0.05, 0.1, 0.5, 1, 2, 5, 10]and label names["route", "status"]rateLimitMetricsMiddlewareinsrc/routes/rate-limit.tsthat records request duration on every response usingprocess.hrtime.bigint(), registered before the admin auth checktests/rate-limit.test.tscovering:Verification Results
rate_limit_request_duration_secondswith[0.01..10]buckets,routeandstatuslabelsrequireAdminon the routerregister.metrics()