feat: Add DB index for health lookup hot path - #708
Open
Ugooweb wants to merge 1 commit into
Open
Conversation
|
@Ugooweb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #611
This PR replaces the mock in-memory state used by the health API endpoints with a proper database lookup. To ensure the new hot path is performant, it also adds an EXPLAIN-verified index on the specific filter columns.
Problem Statement
The
/api/healthendpoints were using a mock memory state (currentHealthState) which wouldn't scale or synchronize correctly across instances. While the/mutationsendpoint persisted an audit log (action = "health.state_mutation"), the GET request didn't fetch the active state from the database. Furthermore, queryingaudit_logsby action and sorting by creation date lacked an index, which would eventually lead to slow sequential scans.Solution
src/routes/health.tsto fetch the latest state from theaudit_logstable.migrations/health_index.sqlto add a specific index on(action, created_at DESC)inaudit_logsto optimize the lookup query.Changes
1. migrations/health_index.sql
UPmigration to createidx_audit_logs_action_created_atindex onaudit_logs.DOWNmigration for rollback capability.2. src/routes/health.ts
currentHealthStatewith a database query onaudit_logs.GET /to query the latesthealth.state_mutationand return theafterState.POST /mutationsto retrieve the current state from the database before applying updates.3. tests/health.test.ts
db.select()to simulate database responses.GET /healthendpoint correctly handles the database state.POST /health/mutationsfunctionality.Security Considerations
Acceptance Criteria
(action, created_at).