ENH: Track physicsnemo_mgn_heart weights via Git LFS#95
Conversation
WalkthroughUpdates Git LFS tracking rules and refreshes the heart MeshGraphNet model assets, including model metadata, geometry, PCA files, and shared edge data. ChangesHeart model assets
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.44.1)tutorials/network_weights/physicsnemo_mgn_heart/pca_model.jsonast-grep skipped this file: it is too large to scan (623801511 bytes) 🔧 Checkov (3.3.8)tutorials/network_weights/physicsnemo_mgn_heart/pca_model.jsonCheckov skipped this file: it is too large to scan (623801511 bytes) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.gitattributes (1)
4-7: 🩺 Stability & Availability | 🔵 TrivialConfirm the referenced LFS objects are uploaded.
These files are pointer stubs; verify a clean checkout can run
git lfs pulland load the model, PCA, mesh, and edge assets before merging.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.gitattributes around lines 4 - 7, Verify that every Git LFS asset matched by the physicsnemo_mgn_heart entries in .gitattributes has been uploaded and is retrievable: perform a clean checkout, run git lfs pull, and confirm the model, PCA, mesh, and edge files load successfully before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@tutorials/network_weights/physicsnemo_mgn_heart/mgn_stage_model_metadata.json`:
- Line 80: Replace the machine-specific absolute value in the resumed_from
metadata field with a portable repository-relative checkpoint path, checkpoint
basename, or stable run ID, while preserving the metadata’s reference to the
resumed checkpoint.
---
Nitpick comments:
In @.gitattributes:
- Around line 4-7: Verify that every Git LFS asset matched by the
physicsnemo_mgn_heart entries in .gitattributes has been uploaded and is
retrievable: perform a clean checkout, run git lfs pull, and confirm the model,
PCA, mesh, and edge files load successfully before merging.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 619f3bed-7fbe-4d02-9ade-41ef90865d8e
📒 Files selected for processing (9)
.gitattributes.gitignoretutorials/network_weights/physicsnemo_mgn_heart/mgn_stage_model.pttutorials/network_weights/physicsnemo_mgn_heart/mgn_stage_model_metadata.jsontutorials/network_weights/physicsnemo_mgn_heart/pca_mean.vtututorials/network_weights/physicsnemo_mgn_heart/pca_mean_surface.vtptutorials/network_weights/physicsnemo_mgn_heart/pca_model.jsontutorials/network_weights/physicsnemo_mgn_heart/shared_edge_features.pttutorials/network_weights/physicsnemo_mgn_heart/shared_edge_index.pt
| ], | ||
| "displacement_scale": 21.72310447692871, | ||
| "displacement_convention": "Option B: relative to subject reference surface", | ||
| "resumed_from": "C:\\src\\Projects\\PhysioTwin4D\\physiotwin4d\\tutorials\\output\\tutorial_09_byod_mgn_2\\mgn_stage_model_epoch_00200.pt", |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove the machine-specific absolute checkpoint path.
Store a repository-relative path, checkpoint basename, or stable run ID instead of committing C:\src\Projects\...; the current value is not portable.
Proposed fix
- "resumed_from": "C:\\src\\Projects\\PhysioTwin4D\\physiotwin4d\\tutorials\\output\\tutorial_09_byod_mgn_2\\mgn_stage_model_epoch_00200.pt",
+ "resumed_from": "mgn_stage_model_epoch_00200.pt",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "resumed_from": "C:\\src\\Projects\\PhysioTwin4D\\physiotwin4d\\tutorials\\output\\tutorial_09_byod_mgn_2\\mgn_stage_model_epoch_00200.pt", | |
| "resumed_from": "mgn_stage_model_epoch_00200.pt", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@tutorials/network_weights/physicsnemo_mgn_heart/mgn_stage_model_metadata.json`
at line 80, Replace the machine-specific absolute value in the resumed_from
metadata field with a portable repository-relative checkpoint path, checkpoint
basename, or stable run ID, while preserving the metadata’s reference to the
resumed checkpoint.
Summary by CodeRabbit
New Features
Bug Fixes
Chores