Bootstrap: unblock Zend spine — mimeheader builtins + cross-unit traits (#22642)#23124
Merged
Merged
Conversation
…ts (#22642) Honest full-spine AOT died at VmMbstring::encodeMimeheader STATICCALL_INIT and at ClassConstFetchHelper's cross-unit trait use. Call mb_* builtins on the spine smoke entry and skip TraitClassConstConflictCheck when the trait AST lives in a prior include unit. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 25, 2026
Bootstrap: unblock gen-0 spine refresh — docblock, ghost require, exclusive launcher (#22642)
#22717
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mb_encode_mimeheader/mb_decode_mimeheaderinstead ofVmMbstring::encodeMimeheader()STATICCALL_INIT (r13 failure after ~4.6h honest Zend full-spine AOT).TraitClassConstConflictCheckskips traits whose AST lives in a prior include unit so incremental AOT can compileClassConstFetchHelperafterClassConstFetchHelperTrait.Extracted from DIRTY #22717 (most of that PR already landed via #23032/#23034/#23035/…). Does not close the verified-fresh gen-0 seed rebuild (28 GiB working set / split-compilation still open on closed #22642).
Test plan
php script/check-selfhost-spine-coverage-sync.php→ OK 6541/6541./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter "BootstrapLibSpineVmSmokeTest|ClassConstFetchRuntimeShrinkTest"'→ OK (20 tests, 70 assertions)Verification
Refs #22642 · supersedes remaining unmerged bits of #22717
Made with Cursor