Skip to content

Package bluetooth manager and movehub separately - #55

Draft
HaudinFlorence wants to merge 20 commits into
mainfrom
package-bluetooth-manager-and-movehub-separately
Draft

Package bluetooth manager and movehub separately#55
HaudinFlorence wants to merge 20 commits into
mainfrom
package-bluetooth-manager-and-movehub-separately

Conversation

@HaudinFlorence

Copy link
Copy Markdown
Member

No description provided.

Comment thread package.json Outdated
Comment on lines 40 to 48
"eslint": "jlpm eslint:check --fix",
"eslint:check": "eslint . --cache --ext .ts,.tsx",
"install:extension": "jlpm build",
"lint": "jlpm stylelint && jlpm prettier && jlpm eslint",
"lint:check": "jlpm stylelint:check && jlpm prettier:check && jlpm eslint:check",
"prettier": "jlpm prettier:base --write --list-different",
"prettier:base": "prettier \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",
"prettier:check": "jlpm prettier:base --check",
"stylelint": "jlpm stylelint:check --fix",
"stylelint:check": "stylelint --cache \"style/**/*.css\"",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also use lerna for lint scripts

Comment thread LICENSE

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep a license there, and copy it in both underlying packages

Comment thread package.json Outdated
"yjs": "^13.5.0"
"style-loader": "^3.3.1"
},
"sideEffects": [

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root package.json does not need this I believe.

Comment thread tsconfig.json Outdated
"strict": false
},
"include": ["src/**/*"],
"include": ["packages/bluetooth/src/**/*", "packages/bluetooth-extension/src/**/*"],

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit odd, we should probably have a tsconfig.json in the underlying packages

@HaudinFlorence
HaudinFlorence force-pushed the package-bluetooth-manager-and-movehub-separately branch 2 times, most recently from 9868a1c to f6c3c57 Compare August 12, 2026 13:52
…nto account.

Restore and update global LICENSE file and add similar files in the packages.
@HaudinFlorence
HaudinFlorence force-pushed the package-bluetooth-manager-and-movehub-separately branch 2 times, most recently from 8903cdf to 64602ef Compare August 13, 2026 10:09
@HaudinFlorence
HaudinFlorence force-pushed the package-bluetooth-manager-and-movehub-separately branch from 64602ef to e6cf3bc Compare August 13, 2026 12:35
@HaudinFlorence
HaudinFlorence force-pushed the package-bluetooth-manager-and-movehub-separately branch 2 times, most recently from 873f077 to afbf1aa Compare August 13, 2026 15:09
@HaudinFlorence
HaudinFlorence force-pushed the package-bluetooth-manager-and-movehub-separately branch from afbf1aa to 4e40520 Compare August 14, 2026 09:09
@HaudinFlorence
HaudinFlorence force-pushed the package-bluetooth-manager-and-movehub-separately branch 6 times, most recently from aff6503 to 125033a Compare August 17, 2026 08:43
@HaudinFlorence
HaudinFlorence force-pushed the package-bluetooth-manager-and-movehub-separately branch 2 times, most recently from 6328e93 to 52eb84c Compare August 17, 2026 08:57
@HaudinFlorence
HaudinFlorence force-pushed the package-bluetooth-manager-and-movehub-separately branch from 52eb84c to becceba Compare August 17, 2026 09:01
@HaudinFlorence
HaudinFlorence force-pushed the package-bluetooth-manager-and-movehub-separately branch 5 times, most recently from 4d75ad7 to 6fe0a28 Compare August 17, 2026 12:48
@HaudinFlorence
HaudinFlorence force-pushed the package-bluetooth-manager-and-movehub-separately branch from 6fe0a28 to 4b12f9b Compare August 17, 2026 13:02
@HaudinFlorence
HaudinFlorence force-pushed the package-bluetooth-manager-and-movehub-separately branch from 9a0ec9b to cb1f605 Compare August 17, 2026 13:46
@HaudinFlorence
HaudinFlorence force-pushed the package-bluetooth-manager-and-movehub-separately branch 4 times, most recently from ecfaa35 to a0ca25f Compare August 17, 2026 15:09
@HaudinFlorence
HaudinFlorence force-pushed the package-bluetooth-manager-and-movehub-separately branch from a0ca25f to b302c92 Compare August 17, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants