Use GIT_CREDENTIAL_CALLBACK=0 to disable use of credential callback#172
Open
ianthomas23 wants to merge 1 commit into
Open
Use GIT_CREDENTIAL_CALLBACK=0 to disable use of credential callback#172ianthomas23 wants to merge 1 commit into
GIT_CREDENTIAL_CALLBACK=0 to disable use of credential callback#172ianthomas23 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
+ Coverage 88.16% 88.18% +0.02%
==========================================
Files 63 63
Lines 2991 2997 +6
Branches 373 376 +3
==========================================
+ Hits 2637 2643 +6
Misses 354 354 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Wasm tests all pass https://github.com/QuantStack/git2cpp/actions/runs/28231520400/job/83636164940 so this is good for review now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to disable the use of the
libgit2credential callback which requests a username and password from the user, using an environment variableGIT_CREDENTIAL_CALLBACK=0. Possible use cases for this are:I considered a number of other possible environment variables:
GIT_DISABLE_CREDENTIALS=1GIT_DISABLE_CREDENTIAL_CALLBACK=1GIT_NO_CREDENTIAL_CALLBACK=1and in the end I have opted for what I think is the least bad option. I could easily be persuaded to use a different one.
If you disable the callback then a request that requires authentication will fail with the following error message: