ci: fail closed on aggregate QPK pin conflicts - #296
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ff886f4dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| src/quant_platform_kit.egg-info/PKG-INFO \ | ||
| src/quant_platform_kit.egg-info/SOURCES.txt | ||
| resolver_python="$resolver_env/bin/python" | ||
| if ! "$resolver_python" -m pip install -r qsl-pins.txt >"$resolver_log" 2>&1; then |
There was a problem hiding this comment.
When the strategy repos still declare their previous direct QPK pin—the normal state until downstream sync runs—pip install -r qsl-pins.txt installs both the newly rewritten QPK requirement and those strategy packages as top-level requirements (pip install --help describes -r as installing from the requirements file), so pip rejects the aggregate before the PR step can run. Because scripts/open_downstream_qpk_pin_prs.py reads the landed QPK_PIN to open downstream alignment PRs, this ordering deadlocks ordinary QPK pushes: the pin PR never opens, so downstream never gets the canonical SHA needed to resolve the conflict.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
No pin manifest, production Python, provider, runtime, deployment, or downstream workflow dispatch change.