Skip to content

fix: Periodic boundary conditions space mismatch for non-self-dual spaces#462

Merged
lkdvos merged 3 commits into
mainfrom
ld-space
Jul 14, 2026
Merged

fix: Periodic boundary conditions space mismatch for non-self-dual spaces#462
lkdvos merged 3 commits into
mainfrom
ld-space

Conversation

@lkdvos

@lkdvos lkdvos commented Jul 14, 2026

Copy link
Copy Markdown
Member

As brought up by @minalouschleith, non-self-dual spaces had a mistake in the fused spaces which led to space mismatches.

Also found a small mistake in the kitaev model test version that should now be fixed.

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/algorithms/toolbox.jl 97.86% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos
lkdvos merged commit 495e1bd into main Jul 14, 2026
0 of 3 checks passed
@lkdvos
lkdvos deleted the ld-space branch July 14, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant