Skip to content

Test QR rules with CUDA#241

Merged
kshyatt merged 10 commits into
mainfrom
ksh/cuqr
Jul 15, 2026
Merged

Test QR rules with CUDA#241
kshyatt merged 10 commits into
mainfrom
ksh/cuqr

Conversation

@kshyatt

@kshyatt kshyatt commented Jun 1, 2026

Copy link
Copy Markdown
Member

No description provided.

@kshyatt

kshyatt commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

OK, this is now working for QR on full CuMatrix, but there are still scalar indexing errors for Diagonal because dispatch for SubArray{T, 2, Diagonal{T, CuVector{T}} is awful. I'd be ok with merging this as-is if the pullback modifications look ok, and then come back for another swing at the Diagonal case.

@kshyatt
kshyatt requested review from Jutho and lkdvos and removed request for Jutho June 4, 2026 15:48
Comment thread src/pullbacks/qr.jl Outdated

@lkdvos lkdvos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to introduce a project_triu(!) and/or norm_triu function for this, and just overload the GPU ones to allocate?

As a side note, we might at some point try and not generate any of the gauge dependency checks if the tolerance is set to 0, as a way to disable the warnings, or alternatively put the entire thing in a @warn block so we can disable that, since these checks are starting to feel a bit expensive if we need to start allocating.

@kshyatt

kshyatt commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

Would it make sense to introduce a project_triu(!) and/or norm_triu function for this, and just overload the GPU ones to allocate?

Yeah I think that could be a nice way to handle it, however I'm unsure if it's that helpful if it's only used in these checks.

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/pullbacks/qr.jl 97.02% <100.00%> (+1.47%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/pullbacks/qr.jl Outdated
Comment thread src/pullbacks/qr.jl Outdated
@kshyatt

kshyatt commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

The Enzyme windows fail is happening on main and seems unrelated

Comment thread src/pullbacks/qr.jl
@kshyatt
kshyatt merged commit 1a1dda3 into main Jul 15, 2026
48 checks passed
@kshyatt
kshyatt deleted the ksh/cuqr branch July 15, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants