Add cancellable DTLS session interruption - #35
Open
Jason-Morcos wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A caller can bound
connect(), but it cannot cancel an attempt that is no longer needed. Shutdown also cannot distinguish between stopping new work while preserving an established DTLS session for normal close and immediately dropping local I/O.Changes
connect(cancel=...)using athreading.Event.quiesce_for_close()to stop new work, interrupt an in-progress connection, and wake response waiters while retaining an established session forclose().abort()to close established local I/O immediately.SessionClosedErrorfor cancellation and shutdown interruption.Synchronous TLS context and endpoint setup are checked immediately before and after each phase; Python cannot preempt those calls while they are executing.
Validation
Tests cover pre-cancellation, cancellation during every published handshake phase, retry-cadence preservation, cancellation after reported success, retry after per-call cancellation, quiescing an in-flight socket, atomic pending-request wakeup, blocked send/read interruption, repeated abort, and reader/pacing shutdown.
Stack
Depends on #34, which depends on #33. Until those PRs merge, GitHub includes their commits in this PR comparison; the new commit for this slice is
ecc963e.Authenticated close-alert flushing and session-generation invalidation remain separate follow-ups.