[AIMIGRAPHX-885] Add concat reshape matcher#4984
Merged
Merged
Conversation
Handles concat(unsqueeze(x_i, A), ..., axis=A) where the unsqueeze inserts a new dimension at the concat axis and rewrites it to reshape(concat(x_i, ..., axis=A)). find_concat_reshape cannot canonicalize this pattern because its pre/post element-product axis mapping fails when a unit dimension is inserted exactly at the concat axis.
Covers the concat-axis == unsqueeze-axis case that the existing concat_unsqueeze test does not exercise (that one is handled by find_concat_reshape). Fails on develop without the new matcher.
Regressions detected 🔴 |
|
TedThemistokleous
marked this pull request as ready for review
June 18, 2026 21:01
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4984 +/- ##
========================================
Coverage 92.73% 92.74%
========================================
Files 592 594 +2
Lines 31289 31351 +62
========================================
+ Hits 29015 29074 +59
- Misses 2274 2277 +3
🚀 New features to boost your workflow:
|
pfultz2
reviewed
Jun 23, 2026
pfultz2
approved these changes
Jun 23, 2026
CharlieL7
requested changes
Jun 24, 2026
CharlieL7
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds a matcher for the concat_reshape matching. Partial piece when breaking up #4723
Technical Details
Partial changes to allow for MLP batched towers and uses this concat_rehsape matcher
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable