Sync device and barrier DMA threads before timing bidirectional trans…#333
Closed
saleelk wants to merge 1 commit into
Closed
Sync device and barrier DMA threads before timing bidirectional trans…#333saleelk wants to merge 1 commit into
saleelk wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the accuracy of DMA bidirectional transfer timing by ensuring the GPU is quiescent before timing begins and by synchronizing per-transfer worker threads so they start timed copies together.
Changes:
- Add
hipDeviceSynchronize()inRunDmaExecutorprior to launching DMA transfer threads to reduce timing skew from prior device work. - Introduce a per-executor atomic “ready” barrier so all transfer threads are running before any begins its timed copy.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
saleelk
force-pushed
the
users/saleelk/SyncExec
branch
from
July 14, 2026 19:37
99e06c3 to
274d822
Compare
…fers Add hipDeviceSynchronize() in RunDmaExecutor to ensure the device is quiescent before starting the timer. Introduce an atomic spin-barrier so all per-transfer threads are running before any begins its timed copy, ensuring accurate bidirectional bandwidth measurement.
saleelk
force-pushed
the
users/saleelk/SyncExec
branch
from
July 14, 2026 19:42
274d822 to
8954a8a
Compare
Collaborator
|
barrier shows poor performance on some architectures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fers
Add hipDeviceSynchronize() in RunDmaExecutor to ensure the device is quiescent before starting the timer. Introduce an atomic spin-barrier so all per-transfer threads are running before any begins its timed copy, ensuring accurate bidirectional bandwidth measurement.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist