TransferBench v1.69#337
Closed
AtlantaPepsi wants to merge 5 commits into
Closed
Conversation
## Motivation Adds a performance debug option that disables validation, so only the initialization and actual transfers execute. Previously, `ALWAYS_VALIDATE` was a boolean (0 = validate once at the end, 1 = validate every iteration), with no way to skip validation entirely. This makes it difficult to isolate pure transfer/initialization cost from validation overhead. ## Technical Details Adds a "disable" option to `ALWAYS_VALIDATE` while preserving the existing 0/1 behavior (backward compatible): - `ALWAYS_VALIDATE=-1` — validation **disabled** (init + transfers only) - `ALWAYS_VALIDATE=0` — validate **once at the end** (default, unchanged) - `ALWAYS_VALIDATE=1` — validate **after each iteration** (unchanged) Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps TransferBench to v1.69 and adjusts transfer/validation behavior to address byte-offset DMA correctness, improve interactive validation handling, and expose a way to disable validation.
Changes:
- Fix DMA executor copies to respect non-zero
BYTE_OFFSETby applying the offset to src/dst pointers. - Extend
ALWAYS_VALIDATEsemantics to support disabling validation (< 0) and update interactive validation prompts/flows accordingly. - Update version strings and changelog for the v1.69 release.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/header/TransferBench.hpp | Updates version, fixes DMA byte-offset handling, and adds <0 validation-disable mode with updated interactive validation behavior. |
| src/client/Utilities.hpp | Prints a clear notice when validation is disabled via ALWAYS_VALIDATE < 0. |
| src/client/EnvVars.hpp | Documents and reports the new ALWAYS_VALIDATE modes (<0/0/>0). |
| src/client/Client.cpp | Modifies the version banner formatting for the client output. |
| CHANGELOG.md | Adds a v1.69.00 entry noting the DMA byte-offset fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+6
to
+9
| ## v1.69.00 | ||
| ### Added | ||
| - Added support for `ALWAYS_VALIDATE=-1` to disable validation | ||
| ### Fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunTransfers()