Skip to content

TransferBench v1.69#341

Merged
AtlantaPepsi merged 9 commits into
developfrom
candidate-1.69-develop
Jul 16, 2026
Merged

TransferBench v1.69#341
AtlantaPepsi merged 9 commits into
developfrom
candidate-1.69-develop

Conversation

@AtlantaPepsi

@AtlantaPepsi AtlantaPepsi commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Fixes for non-zero bytes offset in DMA executor
  • Updated documentation together with ROCm 7.14 release
  • Fixes invalid host access to GPU subExecParam on platforms without large BAR, for GFX executor
  • Fixes a missing device synchronize after input hipMemcpy in RunTransfers()
  • Adds an option to disable validation
  • Adds support for dynamic loading IB verbs (Dynamic Loading IB verbs #253)
  • Fixes array out of bound during validation for empty transfers list, as well as AllToAll presets which may incur empty transfers

gilbertlee-amd and others added 6 commits July 6, 2026 15:36
@gilbertlee-amd
Fix for using byte offsets with DMA executors (#330)
f8064da
@nileshnegi @cursoragent
[debug] option to disable validation (#334)
ec8d0d2 
## Motivation

Adds a performance debug option that disables validation, so only the initialization and actual transfers execute.

Previously, `ALWAYS_VALIDATE` was a boolean (0 = validate once at the end, 1 = validate every iteration), with no way to skip validation entirely. This makes it difficult to isolate pure transfer/initialization cost from validation overhead.

## Technical Details

Adds a "disable" option to `ALWAYS_VALIDATE` while preserving the existing 0/1 behavior (backward compatible):

- `ALWAYS_VALIDATE=-1` — validation **disabled** (init + transfers only)
- `ALWAYS_VALIDATE=0` — validate **once at the end** (default, unchanged)
- `ALWAYS_VALIDATE=1` — validate **after each iteration** (unchanged)

Co-authored-by: Cursor <cursoragent@cursor.com>
@nileshnegi
Merge branch 'develop' into candidate
cd7fa5e
@AtlantaPepsi
Update CHANGELOG.md for v1.69 (#338)
8287494
@AtlantaPepsi
quick fix for string literal (#340)
cd0a077
@AtlantaPepsi
Dynamic Loading IB verbs (#253)
f69f9c2
Copilot AI review requested due to automatic review settings July 15, 2026 22:59
@AtlantaPepsi
AtlantaPepsi requested review from a team as code owners July 15, 2026 22:59
Copilot AI reviewed Jul 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

TransferBench v1.69 update that (a) fixes several transfer/offset/validation behaviors and (b) changes RDMA/NIC support to be enabled via runtime dlopen/dlsym probing of libibverbs (and DMA-BUF export symbol checks), removing build-host dependencies on libibverbs-dev.

Changes:

  • Add runtime-loaded ibverbs support via new third-party/ibverbs/ headers and gate NIC features on IsIbvSymbolsReady() / IsIbvDmabufPresent().
  • Add ALWAYS_VALIDATE < 0 mode to disable validation and adjust interactive behavior accordingly.
  • Fix non-zero byte-offset handling in the DMA executor paths and update version/changelog/build configs for v1.69.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
third-party/ibverbs/IbvHeader.hpp Adds a minimal ibverbs ABI header used by the runtime loader and NIC executor without relying on system headers.
third-party/ibverbs/IbvDynLoad.hpp Implements dlopen/dlsym loading and availability probing for core RDMA + optional DMA-BUF symbols.
src/header/TransferBench.hpp Switches NIC gating to runtime checks, adds validation-disable mode, and fixes DMA executor offset usage.
src/client/Utilities.hpp Prints a clearer message when validation is disabled.
src/client/Topology.hpp Skips NIC topology output when ibverbs symbols aren’t available at runtime.
src/client/EnvVars.hpp Updates ALWAYS_VALIDATE semantics and gates NIC env var help/printing on runtime ibverbs availability.
src/client/Client.cpp Reports NIC support based on runtime ibverbs loading rather than compile-time flags.
Makefile Removes ibverbs build-time detection/linking and adds -ldl + include path for third-party/ibverbs.
CMakeLists.txt Removes NIC/DMA-BUF opt-in options and always links CMAKE_DL_LIBS while adding third-party/ibverbs includes.
CHANGELOG.md Documents v1.69 additions/fixes.
build_packages_local.sh Drops no-longer-relevant NIC/DMA-BUF CMake flags.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread third-party/ibverbs/IbvHeader.hpp
Comment thread third-party/ibverbs/IbvDynLoad.hpp
Copilot AI review requested due to automatic review settings July 15, 2026 23:09
Copilot AI reviewed Jul 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Comment thread third-party/ibverbs/IbvHeader.hpp
Comment thread third-party/ibverbs/IbvDynLoad.hpp
Comment thread third-party/ibverbs/IbvHeader.hpp
Copilot AI review requested due to automatic review settings July 16, 2026 00:22
Copilot AI reviewed Jul 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@AtlantaPepsi
AtlantaPepsi force-pushed the candidate-1.69-develop branch from 2b1cf70 to 1569dfa Compare July 16, 2026 01:58
Copilot AI review requested due to automatic review settings July 16, 2026 01:58
Copilot AI reviewed Jul 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Comment thread src/header/TransferBench.hpp Outdated
@AtlantaPepsi
Potential fix for pull request finding
dea4d82 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 16, 2026 02:03
Copilot AI reviewed Jul 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Comment thread src/header/TransferBench.hpp
Comment thread third-party/ibverbs/IbvDynLoad.hpp
@AtlantaPepsi
AtlantaPepsi merged commit 5fbfa95 into develop Jul 16, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@nileshnegi nileshnegi nileshnegi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AtlantaPepsi @nileshnegi @gilbertlee-amd