[stm32][drivers] Add BDMA support for SPI by moment-NEW · Pull Request #11689 · RT-Thread/rt-thread

moment-NEW · 2026-08-09T08:30:37Z

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

对于H7系列的SPI，其缺失BDMA驱动，因此制作了相关驱动使其正常工作

你的解决方案是什么 (what is your solution)

仿照drv_dma的设计，在驱动层单独设计了一套bdma驱动，而上层spi处基本复用dma逻辑。

请提供验证的bsp和config (provide the config and bsp)

已在DM-MC02 上完成验证工作，验证使用自行编写的WS2812驱动软件包，测试正常点亮，效果与阻塞一致，且不影响串口等其他外设。该BSP以及相关软件包会稍后进行格式清理等后推送。此外进行了scons -j8等编译均通过。

BSP:bsp/stm32/stm32h723-DM-MC02

.config:

action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用clang-format 源码格式化工具确保格式符合RT-Thread代码规范 This PR has been formatted with clang-format and complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

github-actions · 2026-08-09T08:30:45Z

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

前往 Actions 页面 | Go to the Actions page
点击进入工作流 → | Click to open workflow →
点击 Run workflow | Click Run workflow

设置需排除的文件/目录（目录请以"/"结尾）
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to：feat/spi-bdma
设置PR number为 \ Set the PR number to：11689

等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 feat/spi-bdma 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the feat/spi-bdma branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

github-actions · 2026-08-09T08:30:50Z

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: @Liang1795 @hamburger-os @wdfk-prog

Changed Files (Click to expand)

bsp/stm32/libraries/HAL_Drivers/drivers/SConscript
bsp/stm32/libraries/HAL_Drivers/drivers/config/h7/dma_config.h
bsp/stm32/libraries/HAL_Drivers/drivers/config/h7/spi_config.h
bsp/stm32/libraries/HAL_Drivers/drivers/drv_dma.c
bsp/stm32/libraries/HAL_Drivers/drivers/drv_dma.h
bsp/stm32/libraries/HAL_Drivers/drivers/drv_spi.c
bsp/stm32/libraries/HAL_Drivers/drivers/drv_spi.h

📊 Current Review Status (Last Updated: 2026-08-16 19:51 CST)

⌛ @Liang1795 Pending Review
⌛ @hamburger-os Pending Review
⌛ @wdfk-prog Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

github-actions · 2026-08-09T08:34:11Z

MemBrowse Memory Report

stm32f407-rt-spark

CODE: .text +284 B (+0.3%, 86,012 B / 1,048,576 B, total: 8% used)

stm32l475-atk-pandora-llvm

ROM: .text +312 B (+0.4%, 83,696 B / 524,288 B, total: 16% used)

moment-NEW · 2026-08-09T08:38:26Z

现在还是草稿阶段...稍后整理一下BSP部分,开启一个BSP的PR再推上来吧

wdfk-prog · 2026-08-09T09:01:03Z

现在还是草稿阶段...稍后整理一下BSP部分,开启一个BSP的PR再推上来吧

这个bdma没有必要单独开展一个文件的;

struct stm32_bdma_config
{
    void *Instance;                      /**< BDMA channel instance pointer. */
    rt_uint32_t dma_rcc;                 /**< RCC enable bit for the BDMA controller. */
    IRQn_Type dma_irq;                   /**< NVIC IRQ number for the BDMA channel. */
    rt_uint32_t priority;                /**< BDMA transfer priority. */
    rt_uint8_t preempt_priority;         /**< NVIC preempt priority for the BDMA IRQ. */
    rt_uint8_t sub_priority;             /**< NVIC sub priority for the BDMA IRQ. */
    rt_uint32_t request;                 /**< BDMA request selector. */
    rt_uint32_t direction;               /**< BDMA transfer direction. */
    rt_uint32_t periph_inc;              /**< Peripheral address increment mode. */
    rt_uint32_t mem_inc;                 /**< Memory address increment mode. */
    rt_uint32_t periph_data_alignment;   /**< Peripheral data alignment. */
    rt_uint32_t mem_data_alignment;      /**< Memory data alignment. */
    rt_uint32_t mode;                    /**< BDMA transfer mode. */
};

就像stm32_dma_config中关于GPDMA的特殊处理这样对BDMA进行处理就好了
stm32_dma_config中也有channel
你可以看看BDMA中有什么特殊的结构体添加到stm32_dma_config中用宏隔开即可.
这样子可以不再需要一个BDMA的文件了
虽然这样子还是不够简洁,但是把dma逻辑散落到不同文件里面也是更难维护的

/**
 * @brief Static DMA endpoint description used by board-level config headers.
 *
 * This descriptor stores one complete DMA endpoint configuration so peripheral
 * drivers can initialize DMA directly from the board-level config tables.
 */
struct stm32_dma_config
{
    DMA_INSTANCE_TYPE *Instance;        /**< DMA controller instance pointer. */
    rt_uint32_t dma_rcc;                /**< RCC enable bit for the DMA controller. */
    IRQn_Type dma_irq;                  /**< DMA global IRQ number. */
    rt_uint32_t priority;               /**< DMA transfer priority. */
    rt_uint8_t preempt_priority;        /**< NVIC preempt priority for the DMA IRQ. */
    rt_uint8_t sub_priority;            /**< NVIC sub priority for the DMA IRQ. */

#if defined(STM32_DMA_USES_GPDMA)
    rt_uint32_t request;                /**< DMA request selector for the GPDMA channel. */
    rt_uint32_t blk_hw_request;         /**< GPDMA block hardware request mode. */
    rt_uint32_t direction;              /**< DMA transfer direction. */
    rt_uint32_t src_inc;                /**< GPDMA source increment mode. */
    rt_uint32_t dest_inc;               /**< GPDMA destination increment mode. */
    rt_uint32_t src_data_width;         /**< GPDMA source data width. */
    rt_uint32_t dest_data_width;        /**< GPDMA destination data width. */
    rt_uint32_t src_burst_length;       /**< GPDMA source burst length. */
    rt_uint32_t dest_burst_length;      /**< GPDMA destination burst length. */
    rt_uint32_t transfer_allocated_port;/**< GPDMA allocated port selection. */
    rt_uint32_t transfer_event_mode;    /**< GPDMA transfer event mode. */
    rt_uint32_t mode;                   /**< DMA transfer mode. */
#else
#ifdef STM32_DMA_USES_CHANNEL
    rt_uint32_t channel;                /**< DMA channel selector for stream-based DMA. */
#endif /* STM32_DMA_USES_CHANNEL */

#ifdef STM32_DMA_USES_REQUEST
    rt_uint32_t request;                /**< DMA request selector for DMAMUX/request-based DMA. */
#endif /* STM32_DMA_USES_REQUEST */

    rt_uint32_t direction;              /**< DMA transfer direction. */
    rt_uint32_t periph_inc;             /**< Peripheral address increment mode. */
    rt_uint32_t mem_inc;                /**< Memory address increment mode. */
    rt_uint32_t periph_data_alignment;  /**< Peripheral data alignment. */
    rt_uint32_t mem_data_alignment;     /**< Memory data alignment. */
    rt_uint32_t mode;                   /**< DMA transfer mode. */

#if defined(STM32_DMA_SUPPORTS_FIFO)
    rt_uint32_t fifo_mode;              /**< FIFO enable state. */
    rt_uint32_t fifo_threshold;         /**< FIFO threshold selection. */
    rt_uint32_t mem_burst;              /**< Memory burst transfer mode. */
    rt_uint32_t periph_burst;           /**< Peripheral burst transfer mode. */
#endif /* defined(STM32_DMA_SUPPORTS_FIFO) */
#endif /* defined(STM32_DMA_USES_GPDMA) */
};

我看了一些结构体的不同之处,好像并没有不同的地方?所有bdma可以使用Koconfig选择后把STM32_DMA_USES_REQUEST宏一并选择即可;这样BDMA的结构体就完成定义了
至于具体的函数代码还有什么不同,我还没有查看;我认为应该可以在现有的dma代码中进行通过宏定义?或者flag?方案进行对于不同逻辑的使用和转接

moment-NEW · 2026-08-09T09:30:37Z

现在还是草稿阶段...稍后整理一下BSP部分,开启一个BSP的PR再推上来吧

这个bdma没有必要单独开展一个文件的;

struct stm32_bdma_config
{
    void *Instance;                      /**< BDMA channel instance pointer. */
    rt_uint32_t dma_rcc;                 /**< RCC enable bit for the BDMA controller. */
    IRQn_Type dma_irq;                   /**< NVIC IRQ number for the BDMA channel. */
    rt_uint32_t priority;                /**< BDMA transfer priority. */
    rt_uint8_t preempt_priority;         /**< NVIC preempt priority for the BDMA IRQ. */
    rt_uint8_t sub_priority;             /**< NVIC sub priority for the BDMA IRQ. */
    rt_uint32_t request;                 /**< BDMA request selector. */
    rt_uint32_t direction;               /**< BDMA transfer direction. */
    rt_uint32_t periph_inc;              /**< Peripheral address increment mode. */
    rt_uint32_t mem_inc;                 /**< Memory address increment mode. */
    rt_uint32_t periph_data_alignment;   /**< Peripheral data alignment. */
    rt_uint32_t mem_data_alignment;      /**< Memory data alignment. */
    rt_uint32_t mode;                    /**< BDMA transfer mode. */
};

就像stm32_dma_config中关于GPDMA的特殊处理这样对BDMA进行处理就好了
stm32_dma_config中也有channel
你可以看看BDMA中有什么特殊的结构体添加到stm32_dma_config中用宏隔开即可.
这样子可以不再需要一个BDMA的文件了
虽然这样子还是不够简洁,但是把dma逻辑散落到不同文件里面也是更难维护的

/**
 * @brief Static DMA endpoint description used by board-level config headers.
 *
 * This descriptor stores one complete DMA endpoint configuration so peripheral
 * drivers can initialize DMA directly from the board-level config tables.
 */
struct stm32_dma_config
{
    DMA_INSTANCE_TYPE *Instance;        /**< DMA controller instance pointer. */
    rt_uint32_t dma_rcc;                /**< RCC enable bit for the DMA controller. */
    IRQn_Type dma_irq;                  /**< DMA global IRQ number. */
    rt_uint32_t priority;               /**< DMA transfer priority. */
    rt_uint8_t preempt_priority;        /**< NVIC preempt priority for the DMA IRQ. */
    rt_uint8_t sub_priority;            /**< NVIC sub priority for the DMA IRQ. */

#if defined(STM32_DMA_USES_GPDMA)
    rt_uint32_t request;                /**< DMA request selector for the GPDMA channel. */
    rt_uint32_t blk_hw_request;         /**< GPDMA block hardware request mode. */
    rt_uint32_t direction;              /**< DMA transfer direction. */
    rt_uint32_t src_inc;                /**< GPDMA source increment mode. */
    rt_uint32_t dest_inc;               /**< GPDMA destination increment mode. */
    rt_uint32_t src_data_width;         /**< GPDMA source data width. */
    rt_uint32_t dest_data_width;        /**< GPDMA destination data width. */
    rt_uint32_t src_burst_length;       /**< GPDMA source burst length. */
    rt_uint32_t dest_burst_length;      /**< GPDMA destination burst length. */
    rt_uint32_t transfer_allocated_port;/**< GPDMA allocated port selection. */
    rt_uint32_t transfer_event_mode;    /**< GPDMA transfer event mode. */
    rt_uint32_t mode;                   /**< DMA transfer mode. */
#else
#ifdef STM32_DMA_USES_CHANNEL
    rt_uint32_t channel;                /**< DMA channel selector for stream-based DMA. */
#endif /* STM32_DMA_USES_CHANNEL */

#ifdef STM32_DMA_USES_REQUEST
    rt_uint32_t request;                /**< DMA request selector for DMAMUX/request-based DMA. */
#endif /* STM32_DMA_USES_REQUEST */

    rt_uint32_t direction;              /**< DMA transfer direction. */
    rt_uint32_t periph_inc;             /**< Peripheral address increment mode. */
    rt_uint32_t mem_inc;                /**< Memory address increment mode. */
    rt_uint32_t periph_data_alignment;  /**< Peripheral data alignment. */
    rt_uint32_t mem_data_alignment;     /**< Memory data alignment. */
    rt_uint32_t mode;                   /**< DMA transfer mode. */

#if defined(STM32_DMA_SUPPORTS_FIFO)
    rt_uint32_t fifo_mode;              /**< FIFO enable state. */
    rt_uint32_t fifo_threshold;         /**< FIFO threshold selection. */
    rt_uint32_t mem_burst;              /**< Memory burst transfer mode. */
    rt_uint32_t periph_burst;           /**< Peripheral burst transfer mode. */
#endif /* defined(STM32_DMA_SUPPORTS_FIFO) */
#endif /* defined(STM32_DMA_USES_GPDMA) */
};

我看了一些结构体的不同之处,好像并没有不同的地方?所有bdma可以使用Koconfig选择后把STM32_DMA_USES_REQUEST宏一并选择即可;这样BDMA的结构体就完成定义了
至于具体的函数代码还有什么不同,我还没有查看;我认为应该可以在现有的dma代码中进行通过宏定义?或者flag?方案进行对于不同逻辑的使用和转接

关于重复的配置：
确实是如此。BDMA绝大部分配置都是在HAL库上和DMA通用的。但是我还是没有采取dma加宏定义的方式，因为DMA里面宏定义太多了，~~FIFO,Channel,等等有大量的宏编译分支~~(重新看了一下其实也不算很多，把下游SPI的条件编译看进去了），虽然BDMA基本上不用考虑这些，但是再加进去，我觉得会让DMA的可读性大大下降，此外我不是很清楚改动会对其他使用DMA的产生什么影响，比如uart等。
关于结构体不同之处：
也是正因如此，我觉得如果要合并，更合适的可能是单独开一个bdma类型，其能复用setup等逻辑，作为没有FIFO等特殊功能的普通DMA使用，不需要单独走编译分支

- Updated DMA instance type definitions in drv_dma.h to improve readability and maintainability. - Introduced a common DMA configuration structure to streamline DMA and BDMA configurations. - Added BDMA support for STM32H7 series in drv_dma.h, including initialization and configuration functions. - Refactored SPI driver (drv_spi.c) to align with new DMA structure, ensuring compatibility with BDMA. - Cleaned up code formatting and comments for better clarity and consistency across the SPI driver. - Removed unnecessary BDMA includes and configuration macros from drv_spi.h to simplify the header file.

moment-NEW · 2026-08-16T11:55:18Z

@wdfk-prog 您好！我根据您的意见大概修改了一下，不过我选择的是实现了个简单的DMA的类来继承，把原来的DMA和BDMA逻辑都转发到通用的DMA内部处理函数里面。不知道可以可以不可以？

似乎因为本地的formatting过时了所以导致有很大的格式问题。对于可能存在的review干扰非常抱歉

wdfk-prog · 2026-08-16T14:24:02Z

@wdfk-prog 您好！我根据您的意见大概修改了一下，不过我选择的是实现了个简单的DMA的类来继承，把原来的DMA和BDMA逻辑都转发到通用的DMA内部处理函数里面。不知道可以可以不可以？

似乎因为本地的formatting过时了所以导致有很大的格式问题。对于可能存在的review干扰非常抱歉

你能合并一些commit吗?只保留最新两个commit进行提交即可
可以使用git push -f强推一下.

wdfk-prog · 2026-08-16T14:28:15Z

@@ -346,9 +371,117 @@ rt_err_t stm32_dma_deinit(DMA_HandleTypeDef *dma_handle,

 #endif /* HAL_DMA_MODULE_ENABLED */


新增的代码应该包括到这个宏里面

wdfk-prog · 2026-08-16T14:28:56Z

+
+#endif /* BSP_USING_BDMA && (SOC_SERIES_STM32H7 || SOC_SERIES_STM32H7RS) */
+
+#if defined(BSP_USING_BDMA) && (defined(SOC_SERIES_STM32H7) || defined(SOC_SERIES_STM32H7RS))


这个宏不是跟上面的一样的吗?为什么单独又来一个#if

wdfk-prog · 2026-08-16T14:30:43Z


 #endif /* HAL_DMA_MODULE_ENABLED */

+#if defined(BSP_USING_BDMA) && (defined(SOC_SERIES_STM32H7) || defined(SOC_SERIES_STM32H7RS))


L374~L482 这些需要特地区分出来吗?

如果只是为了体现BDMA却跟DMA用法一样的话,不需要额外多这么多定义

wdfk-prog · 2026-08-16T14:33:38Z

+        if (dma_rcc == 0)
+        {
+            LOG_E("bdma enable clock failed, dma_rcc is 0");
+            __HAL_RCC_BDMA_CLK_ENABLE();


这个没看懂,这里是要异常退出吧?为什么还使能BDMA CLK了?

wdfk-prog · 2026-08-16T14:34:43Z

 {
    rt_uint32_t tmpreg = 0x00U;

+#if defined(BSP_USING_BDMA) && (defined(SOC_SERIES_STM32H7) || defined(SOC_SERIES_STM32H7RS))


这一段能跟下面的#if defined(STM32_DMA_USES_RCC_AHBENR)判断逻辑一样放在同一个IF ELIF里面吗?这样子会更好

wdfk-prog · 2026-08-16T14:35:46Z

+#if defined(BSP_USING_BDMA) && (defined(SOC_SERIES_STM32H7) || defined(SOC_SERIES_STM32H7RS))
+    if (is_bdma)
+    {
+        if (dma_rcc == 0)


dma_rcc = 0是异常吗?那可以未所有dma都做判断,而不只是bdma

或者也可以不限制用户的自由?否则的话这里异常退出没有返回值

wdfk-prog · 2026-08-16T14:37:21Z

+ * @param is_bdma RT_TRUE for BDMA clock enable, RT_FALSE for regular DMA.
 */
-static void stm32_dma_enable_clock(rt_uint32_t dma_rcc)
+static void stm32_dma_enable_clock(rt_uint32_t dma_rcc, rt_bool_t is_bdma)


我看不需要增加is_bdma的变量吧?可以在dma_config中增加一个变量传入即可,这样子不需要改动这么多函数和定义

[stm32][drivers] Add BDMA support for SPI

90de17e

github-actions Bot added BSP: STM32 BSP related with ST/STM32 BSP labels Aug 9, 2026

style: format code with clang-format [skip ci]

a9f6c0f

style: format code with clang-format [skip ci]

88b4a16

wdfk-prog reviewed Aug 16, 2026

View reviewed changes

		@@ -346,9 +371,117 @@ rt_err_t stm32_dma_deinit(DMA_HandleTypeDef *dma_handle,

		#endif /* HAL_DMA_MODULE_ENABLED */


		#endif /* BSP_USING_BDMA && (SOC_SERIES_STM32H7 \|\| SOC_SERIES_STM32H7RS) */

		#if defined(BSP_USING_BDMA) && (defined(SOC_SERIES_STM32H7) \|\| defined(SOC_SERIES_STM32H7RS))

Uh oh!

Conversation

moment-NEW commented Aug 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

github-actions Bot commented Aug 9, 2026

🛠 操作步骤 | Steps

Uh oh!

github-actions Bot commented Aug 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

📊 Current Review Status (Last Updated: 2026-08-16 19:51 CST)

📝 Review Instructions

Uh oh!

github-actions Bot commented Aug 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

MemBrowse Memory Report

Uh oh!

moment-NEW commented Aug 9, 2026

Uh oh!

wdfk-prog commented Aug 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moment-NEW commented Aug 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moment-NEW commented Aug 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wdfk-prog commented Aug 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

moment-NEW commented Aug 9, 2026 •

edited

Loading

github-actions Bot commented Aug 9, 2026 •

edited

Loading

github-actions Bot commented Aug 9, 2026 •

edited

Loading

wdfk-prog commented Aug 9, 2026 •

edited

Loading

moment-NEW commented Aug 9, 2026 •

edited

Loading

moment-NEW commented Aug 16, 2026 •

edited

Loading