Account for windows-arm64 builds - #417
Merged
Merged
Conversation
Member
Author
|
This built one more time without issue at r-universe, and as it contains neither new code nor any changes to builds on systems used at CRAN I will for once just merge this to proceed as there is really no need for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #416
As #416 notes, r-universe now build for the Windows OS on arm64 (or 'aarch64') cpus. As there is not blp library (that I am aware of) the solution is to fill in with the 'no blp' compile setting so we add a simple configure layer to check the actual Windows build platform and copy
src/Makevars.no_blpin and otherwise rely as before on the Windows file, now renamed tosrc/Makevars.win.in.This has been tested at r-universe from this branch and is ready.