fix(stream): route content_block_delta to most-recently-started block at index#3
Open
argsno wants to merge 1 commit into
Open
fix(stream): route content_block_delta to most-recently-started block at index#3argsno wants to merge 1 commit into
argsno wants to merge 1 commit into
Conversation
… at index When the SDK reuses a content_block index for two tool_use blocks in one stream (e.g. a read and a bash both at index 2), the delta handler matched blocks by first-match on event.index, so the second block's deltas were appended onto the first block's partialJson. That concatenated the two JSON payloads into one string, parsePartialJson failed, and one tool's arguments (the bash command) were silently dropped. Match the most-recently-started block at the index instead. Stop events keep first-match (they run in start order and each deletes its index), so they still resolve correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the SDK reuses a content_block index for two tool_use blocks in one stream (e.g. a read and a bash both at index 2), the delta handler matched blocks by first-match on event.index, so the second block's deltas were appended onto the first block's partialJson. That concatenated the two JSON payloads into one string, parsePartialJson failed, and one tool's arguments (the bash command) were silently dropped.
Match the most-recently-started block at the index instead. Stop events keep first-match (they run in start order and each deletes its index), so they still resolve correctly.