fix(gendoc): log skipped assemblies in FailureBehavior.Continue#17
Open
Reefact wants to merge 1 commit into
Open
fix(gendoc): log skipped assemblies in FailureBehavior.Continue#17Reefact wants to merge 1 commit into
Reefact wants to merge 1 commit into
Conversation
HandleFailure returned without any trace in Continue mode (the CLI default outside --strict), so target-not-found, worker-produced-no-output, unreadable-output, TargetPath resolution failures and missing assemblies dropped assemblies silently. Emit a Warning (with the exception detail when present) before continuing so every skipped assembly leaves a diagnosable trace. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MUSHBAhJ5R2PFp9HismMZs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problème (B3)
HandleFailurefaisait un simplereturnsans rien logger en modeFailureBehavior.Continue(le comportement du CLI hors--strict) :Résultat : des assemblies étaient sautées sans aucune trace pour tous les appels à
HandleFailure:TargetPathGetErrorDocumentationFromAssembliesSeul le stderr du worker restait visible (via
RunProcess), donc un crash du worker restait diagnosticable, mais tout le reste était silencieux.Correctif
En mode
Continue, on logge désormais systématiquement en Warning avant de continuer, en incluant le détail de l'exception quand elle existe :Warning(et nonError) car enContinuela dégradation est volontaire et non fatale — mais désormais tracée. Le cheminStop(throw deSolutionDocumentationGenerationException) reste inchangé.Tests
Ajout de
ASkippedAssemblyIsLoggedWhenContinuing, qui utilise unIGenerationLoggercapturant et vérifie qu'une assembly manquante émet bien un warning mentionnant le fichier.🤖 Generated with Claude Code
Generated by Claude Code