fix(cli): guard against a renderer returning no documents#19
Open
Reefact wants to merge 1 commit into
Open
Conversation
WriteOutput accessed documents[0] without checking the list was non-empty. The IErrorDocumentationRenderer.Render contract promises at least one document, but a custom renderer can violate it, in which case documents[0] threw an opaque ArgumentOutOfRangeException. Add a guard that fails with a clear message naming the offending renderer format before any documents[0] access. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RZShkZnouh6f1yy6YGaFwx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WriteOutput accessed documents[0] without checking the list was
non-empty. The IErrorDocumentationRenderer.Render contract promises at
least one document, but a custom renderer can violate it, in which case
documents[0] threw an opaque ArgumentOutOfRangeException.
Add a guard that fails with a clear message naming the offending
renderer format before any documents[0] access.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01RZShkZnouh6f1yy6YGaFwx