-
-
Notifications
You must be signed in to change notification settings - Fork 82
RG-T125 IC bug fixes, weather alert fixes #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| using System; | ||
|
|
||
| namespace Resgrid.Model | ||
| { | ||
| /// <summary> | ||
| /// Thrown when a resource assignment (or move) targets a command board lane whose source template | ||
| /// role has <c>ForceRequirements</c> enabled and the resource does not satisfy the lane's required | ||
| /// unit types / personnel roles. The message is safe to surface to the caller. | ||
| /// </summary> | ||
| public class CommandRequirementsNotMetException : Exception | ||
| { | ||
| public CommandRequirementsNotMetException(string message) : base(message) | ||
| { | ||
| } | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ public enum MessageTypes | |
| { | ||
| Normal = 0, | ||
| Callback = 1, | ||
| Poll = 2 | ||
| Poll = 2, | ||
| WeatherAlert = 3 | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -36,6 +36,14 @@ public interface ICommandsService | |||||||||||||||||||||||||||||
| /// <returns>Task<CommandDefinition>.</returns> | ||||||||||||||||||||||||||||||
| Task<CommandDefinition> GetCommandForCallTypeAsync(int departmentId, int? callTypeId); | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| /// <summary> | ||||||||||||||||||||||||||||||
| /// Gets a single lane (role) with its requirement sets (RequiredUnitTypes/RequiredRoles) hydrated. | ||||||||||||||||||||||||||||||
| /// Used to enforce lane requirements when assigning resources on the live command board. | ||||||||||||||||||||||||||||||
| /// </summary> | ||||||||||||||||||||||||||||||
| /// <param name="commandDefinitionRoleId">The lane (command definition role) identifier.</param> | ||||||||||||||||||||||||||||||
| /// <returns>Task<CommandDefinitionRole>.</returns> | ||||||||||||||||||||||||||||||
| Task<CommandDefinitionRole> GetRoleWithRequirementsAsync(int commandDefinitionRoleId); | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
|
Comment on lines
+39
to
+46
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win Add a Per coding guidelines, service methods should expose a ♻️ Suggested signature change- Task<CommandDefinitionRole> GetRoleWithRequirementsAsync(int commandDefinitionRoleId);
+ Task<CommandDefinitionRole> GetRoleWithRequirementsAsync(int commandDefinitionRoleId, bool bypassCache = false);📝 Committable suggestion
Suggested change
🤖 Prompt for AI AgentsSource: Coding guidelines |
||||||||||||||||||||||||||||||
| /// <summary> | ||||||||||||||||||||||||||||||
| /// Deletes the specified command definition. | ||||||||||||||||||||||||||||||
| /// </summary> | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Restrict the replacement to the section heading.
Line 146 rewrites every occurrence in the PR body, including prose and code blocks. Match only the intended Markdown heading so release-note content is preserved.
🤖 Prompt for AI Agents