Conversation
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
📝 WalkthroughWalkthroughThe protobuf warm-up routine now prepares multiple RabbitMQ queue and event payload serializers at startup. ChangesProtobuf serializer warm-up
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Description: RG-T125 Chatbot fix
This pull request fixes an issue with the chatbot messaging functionality by addressing a protobuf serialization defect and adding fail-fast validation for queue message types.
Changes
Added missing
[ProtoContract]attribute toChatbotMessageQueueItem[ProtoMember]attributes but was missing the required[ProtoContract]attribute at the class level. Without it, protobuf-net cannot properly serialize instances of this type, causing failures when chatbot messages are published to the RabbitMQ queue.Extended the Protobuf serializer warmup to cover all queue payload types
SerializerHelper.WarmUpProtobufSerializer()now prepares serializers for every payload type published to RabbitMQ (e.g.,CallQueueItem,MessageQueueItem,ShiftQueueItem,CqrsEvent,AuditEvent, etc.).[ProtoContract]attribute fails immediately on boot rather than surfacing as a runtime error the first time a message of that type is enqueued.Functional Impact
Chatbot messages will now serialize correctly for queue transport, and the application will detect missing protobuf contract attributes early during startup, preventing similar serialization failures across other message types.