Skip to content

Branch with a slash#20

Open
pkaminski wants to merge 9 commits into
masterfrom
pkaminski/ts-file
Open

Branch with a slash#20
pkaminski wants to merge 9 commits into
masterfrom
pkaminski/ts-file

Conversation

@pkaminski

@pkaminski pkaminski commented Sep 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This change is Reviewable

@pkaminski-test

pkaminski-test commented Sep 18, 2025

Copy link
Copy Markdown

ohi

pkaminski
pkaminski commented Sep 19, 2025
View reviewed changes

@pkaminski pkaminski left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publish this on push

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@pkaminski-test

pkaminski-test commented Sep 19, 2025

Copy link
Copy Markdown

Ad-hoc comment

@pkaminski

pkaminski commented Sep 19, 2025

Copy link
Copy Markdown
Member Author

Ad-hoc comment from author

pkaminski-test
pkaminski-test previously requested changes Oct 1, 2025
View reviewed changes

@pkaminski-test pkaminski-test left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion

a discussion (no related file):
Your turn

pkaminski-test
pkaminski-test reviewed Oct 1, 2025
View reviewed changes

@pkaminski-test pkaminski-test left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkaminski-test reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @pkaminski)

@pkaminski

pkaminski commented Oct 1, 2025

Copy link
Copy Markdown
Member Author

A between-commits comment on GitHub.

@pkaminski pkaminski requested review from pkaminski-test and removed request for pkaminski-test October 14, 2025 21:28
pkaminski
pkaminski commented Oct 23, 2025
View reviewed changes

@pkaminski pkaminski left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkaminski reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pkaminski-test)

a discussion (no related file):

Previously, pkaminski-test wrote…

Your turn

Done.

pkaminski
pkaminski commented Oct 23, 2025
View reviewed changes

@pkaminski pkaminski left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkaminski dismissed @pkaminski-test from a discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pkaminski-test)

pkaminski
pkaminski commented Oct 23, 2025
View reviewed changes
Comment thread fresh.ts Outdated
pkaminski
pkaminski commented Oct 23, 2025
View reviewed changes
Comment thread fresh.ts
}
}

// Commit A

@pkaminski pkaminski Oct 23, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another new unresolved comment.

@pkaminski pkaminski Oct 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reply to unresolved comment. Then edited.

@pkaminski pkaminski Oct 23, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reply posted in bigger review.

@pkaminski pkaminski Oct 23, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up comment.

pkaminski
pkaminski commented Oct 23, 2025
View reviewed changes
Comment thread fresh.ts
}
}

// Commit A

@pkaminski pkaminski Oct 23, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reply posted in bigger review.

Comment thread fresh.ts
@pkaminski

pkaminski commented Oct 23, 2025

Copy link
Copy Markdown
Member Author

Issue comment.

@pkaminski

pkaminski commented Oct 23, 2025

Copy link
Copy Markdown
Member Author

Another issue comment.

@pkaminski

pkaminski commented Oct 23, 2025

Copy link
Copy Markdown
Member Author

Once more, with feeling.

pkaminski-test
pkaminski-test reviewed Oct 23, 2025
View reviewed changes

@pkaminski-test pkaminski-test left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foo

pkaminski-test
pkaminski-test requested changes Oct 23, 2025
View reviewed changes

@pkaminski-test pkaminski-test left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bar

@pkaminski

pkaminski commented Dec 9, 2025

Copy link
Copy Markdown
Member Author

-- commits line 18 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

2

2

@pkaminski

pkaminski commented Dec 9, 2025

Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski

pkaminski commented Dec 9, 2025

Copy link
Copy Markdown
Member Author

-- commits line 18 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

2

2

@pkaminski

pkaminski commented Dec 9, 2025

Copy link
Copy Markdown
Member Author

asdf

@pkaminski

pkaminski commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski

pkaminski commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

pkaminski
pkaminski commented Dec 10, 2025
View reviewed changes

@pkaminski pkaminski left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @pkaminski-test)

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

asdf

@pkaminski

pkaminski commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

asdf

1

@pkaminski

pkaminski commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

pkaminski
pkaminski commented Dec 10, 2025
View reviewed changes

@pkaminski pkaminski left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @pkaminski-test)

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski

pkaminski commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski

pkaminski commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski

pkaminski commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski

pkaminski commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski

pkaminski commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski

pkaminski commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

-- commits line 18 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

2

2

@pkaminski

pkaminski commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski

pkaminski commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

pkaminski
pkaminski commented Dec 10, 2025
View reviewed changes

@pkaminski pkaminski left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @pkaminski-test)

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski

pkaminski commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

pkaminski
pkaminski commented Dec 10, 2025
View reviewed changes

@pkaminski pkaminski left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rwer

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @pkaminski-test)

@pkaminski

pkaminski commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

pkaminski
pkaminski commented Dec 10, 2025
View reviewed changes

@pkaminski pkaminski left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3r

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @pkaminski-test)

@pkaminski

pkaminski commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

-- commits line 16 at r4:

Previously, pkaminski (Piotr Kaminski) wrote…

1

1

@pkaminski

pkaminski commented Dec 10, 2025

Copy link
Copy Markdown
Member Author

foo

@pkaminski

pkaminski commented Apr 14, 2026

Copy link
Copy Markdown
Member Author

$E = mc^2$

$$ \int_0^\infty e^{-x} dx = 1 $$

@pkaminski

pkaminski commented May 12, 2026

Copy link
Copy Markdown
Member Author

🏁

@pkaminski

pkaminski commented May 12, 2026

Copy link
Copy Markdown
Member Author

:checkered\_flag:

@pkaminski

pkaminski commented May 12, 2026

Copy link
Copy Markdown
Member Author

🏁

pkaminski
pkaminski commented May 16, 2026
View reviewed changes

@pkaminski pkaminski left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏁

@pkaminski partially reviewed 1 file and made 1 comment.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on pkaminski-test).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkaminski-test pkaminski-test pkaminski-test approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pkaminski @pkaminski-test