feat: implement Pact verification for notifications and update CI wor… - #787
Open
Hunterly01 wants to merge 1 commit into
Open
feat: implement Pact verification for notifications and update CI wor…#787Hunterly01 wants to merge 1 commit into
Hunterly01 wants to merge 1 commit into
Conversation
|
@Hunterly01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
Please merge the issue no error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #724
Summary
This PR adds a consumer-provider contract for the
/notificationsAPI and verifies the live backend handler against it, preventing frontend regressions caused by silent API shape drift.What changed
Why
Frontend regressions repeatedly land when API payloads change without consumer approval. This contract makes response shape changes visible and fails CI when a field is removed or a contract is unexpectedly altered.
Security notes
PACT_BROKER_URLPACT_BROKER_TOKENValidation
I validated the notifications-specific verification path with:
npx jest --runInBand notifications.test.ts notifications.consumer.test.ts src/routes/notifications.pact.test.tsResult: