Add support for ros2 wsting - #336
Open
Carter12s wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
Okay so wstring appears to be fully broken with rosbridge_server which chokes on the messages. That invalidates a lot of the work I've done so far (should have checked on that sooner!). If wstring is only going to be supported by ROS2 native backends (ros-z only currently) then I feel less need to support it (thou would like to do things correctly). For now likely shelving this until I get some movement here: RobotWebTools/rosbridge_suite#1297 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for ROS2 wstring type with sane behavior for other backends.
Fixes
Closes: #322
Checklist