update to rustc 1.98#612
Draft
Firestar99 wants to merge 6 commits into
Draft
Conversation
Closed
92c6cd5 to
442f98b
Compare
442f98b to
0e0dc17
Compare
Member
Author
|
Going from working The only two PRs that change anything in rustc_codegen_ssa in that range are:
UPDATE: We can fix the compiletests by just removing this flag: - "-Cdebuginfo=2",This flag is responsible for controlling debug symbol emission, 2 means all the debug symbols and it defaults to 0 (I think) meaning none. How the hell does turning on debug symbol emission cause fundamental compilation errors?
fn create_function_debug_context(
&self,
_instance: Instance<'tcx>,
_fn_abi: &FnAbi<'tcx, Ty<'tcx>>,
_llfn: Self::Function,
_mir: &mir::Body<'tcx>,
) -> Option<FunctionDebugContext<'tcx, Self::DIScope, Self::DILocation>> {
// TODO: This is ignored. Do we want to implement this at some point?
None
}
I beliebe the fix I made here is only a temporary fix, I suspect any debug build of sufficient complexity will fail. Don't yet know what to do about that. |
a05ddca to
7df0ab3
Compare
7df0ab3 to
f9b1b4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #610
Warning
This is an in-the-middle nightly
Notable changes:
ScalarPairsare passed byPassMode::ScalarPairexclusively. But rust-gpu readjusts the fn abi here to pass any non-sliceScalarPairasPassMode::Direct. Removing this ABI change breaks a bunch of code in all kinds of weird ways, primarilyByteAddressableBufferintrinsics andpanic!()format args decompiler complaining about function pointers and pointer casts. It's just that rust-gpu can't properly handlePassMode::ScalarPairin so many places... So we'll keep our abi adjustments and I just undo that upstream cleanup.close #605