Conversation
Add fixed source to silence generator
The macro allows us to specify an effect once and have it be implemented for `Source`, `FixedSource` and `ConstSource`.
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
review after #910
Tracking issue: #901
Now that we have three source traits we can implement effects for it no longer makes sense to have those effects live in
/src/source. This is the start of moving them tosrc/effects.We use a macro to (usually) define the effect once and get three structs and implementations.
To keep this PR reviewable this only uses this macro for
amplify. To get more context see: https://github.com/RustAudio/rodio-experiments.Note amplify has also been changed. We used to have three different amplify methods now we have one and the logic is all in a new Factor struct which amplify requires.