fix(adms): align all action paths with com.sap.adm.{Service} namespace#184
Open
adwitiyasushant wants to merge 2 commits into
Open
fix(adms): align all action paths with com.sap.adm.{Service} namespace#184adwitiyasushant wants to merge 2 commits into
adwitiyasushant wants to merge 2 commits into
Conversation
Mirrors cloud-sdk-java contrib-java/adms commit e5dd1da's wire-format
audit. The Java audit identified 12 fixes against the canonical CDS
sources + live ADMS tenant. Cross-verified Python state vs CDS:
- 7 fixes were already correct in Python (UpdateDocumentInput fields,
RestoreContentVersion envelope, DeleteContentVersion body shape,
DownloadDocument GET function, StartJob payload, JobStatus function,
LateHostBusinessObjectNodeID casing).
- 5 namespace-prefix fixes were genuinely missing (lock, unlock,
complete_multipart_upload, generate_upload_urls, mark_default) —
Python used the short form which CAP accepts leniently but is not
the canonical OData V4 wire format.
For cross-SDK consistency with Java, ALL 12 bound/unbound action paths
now use the fully-qualified com.sap.adm.{DocumentService,AdminService,
ConfigurationService}.X form:
DocumentService bound actions on DocumentRelation:
UpdateDocument, CompleteMultipartUpload,
RestoreDocumentContentVersion, DeleteDocumentContentVersion,
LockDocumentAndRelation, UnlockDocumentAndRelation,
GenerateDocumentUploadURLs, DownloadDocument (function)
DocumentService unbound:
StartJob, JobStatus (function)
AdminService unbound:
StartJob, JobStatus (function)
ConfigurationService bound on DocumentTypeBusinessObjectTypeMap:
markDefault
Test changes:
- Tightened 7 substring assertions in test_client.py to include the
namespace prefix so the wire contract is captured in tests.
Also includes prior work on this branch:
- extra_headers support on sync + async HTTP verbs (for x-subaccount-id
header on ApplicationTenant operations)
- subaccount_id parameter on all 4 ApplicationTenant config methods
No API surface changes, no model changes, no behavioural changes —
purely wire-protocol alignment with Java commit e5dd1da.
Interactive CLI for testing all ADMS APIs against a real ADM instance. Used during this PR's development to verify each of the 12 wire-format fixes returns the expected response from the live tenant. WILL BE REMOVED BEFORE MERGE — kept in this PR only as a debugging aid so reviewers can reproduce the live-tenant verification if desired. Usage: set -a && source .env.adms && set +a .venv/bin/python scripts/adms_cli.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors cloud-sdk-java contrib-java/adms commit e5dd1da's wire-format audit. The Java audit identified 12 fixes against the canonical CDS sources + live ADMS tenant. Cross-verified Python state vs CDS:
For cross-SDK consistency with Java, ALL 12 bound/unbound action paths now use the fully-qualified com.sap.adm.{DocumentService,AdminService, ConfigurationService}.X form:
DocumentService bound actions on DocumentRelation:
UpdateDocument, CompleteMultipartUpload,
RestoreDocumentContentVersion, DeleteDocumentContentVersion,
LockDocumentAndRelation, UnlockDocumentAndRelation,
GenerateDocumentUploadURLs, DownloadDocument (function)
DocumentService unbound:
StartJob, JobStatus (function)
AdminService unbound:
StartJob, JobStatus (function)
ConfigurationService bound on DocumentTypeBusinessObjectTypeMap:
markDefault
Test changes:
Also includes prior work on this branch:
No API surface changes, no model changes, no behavioural changes — purely wire-protocol alignment with Java commit e5dd1da.
Description
Provide a clear description of your changes here.
Related Issue
Closes #<issue_number>
(Link to the GitHub issue this PR addresses)
Type of Change
Please check the relevant option:
How to Test
Describe how reviewers can test your changes:
Checklist
Before submitting your PR, please review and check the following:
Breaking Changes
If this PR introduces breaking changes, please describe:
Additional Notes
Add any additional context, screenshots, or information that would help reviewers.